You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lriggs (via GitHub)" <gi...@apache.org> on 2026/07/09 22:08:11 UTC
[PR] GH-50457 Add LN alias for LOG [arrow]
lriggs opened a new pull request, #50458:
URL: https://github.com/apache/arrow/pull/50458
### Rationale for this change
`LN` is the standard SQL name for the natural logarithm, while Gandiva exposes it as `log`. Adding `ln` as an alias lets SQL engines that emit `LN(x)` route to the same precompiled `log_<type>` functions without duplicating any C code. The alias mechanism already exists in Gandiva and is used for `pow` (alias of `power`), `trunc` (alias of `truncate`), and `udfdegrees` (alias of `degrees`).
### What changes are included in this PR?
`NativeFunction` accepts a `base_name` and a `std::vector<std::string> aliases`. Each alias gets its own `FunctionSignature` that points to the same precompiled (`pc_name`) function — so `ln_int32` does not need to exist; the alias `"ln"` resolves to the same IR symbol `log_int32`.
The `MATH_UNARY_OPS(name, ALIASES)` macro in `function_registry_math_ops.cc` expands to six `NativeFunction` entries (int32, int64, uint32, uint64, float32, float64), all forwarding to the corresponding `log_<type>` precompiled symbols.
### Are these changes tested?
New unit tests.
### Are there any user-facing changes?
Yes, a new Gandiva function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50457: [C++][Gandiva] Add LN alias for LOG [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50458:
URL: https://github.com/apache/arrow/pull/50458#issuecomment-4976576209
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 83c185bbfcd713f8be81ae6ee47a8d74ed6dfc5e.
There was 1 benchmark result indicating a performance regression:
- Commit Run on `amd64-m5-4xlarge-linux` at [2026-07-13 06:04:38Z](https://conbench.arrow-dev.org/compare/runs/c8fc5710b83e4dfbb572edd3e2c190bd...6b37c541e11e41a693a105ab2750d437/)
- [`dataframe-to-table` (R) with dataset=type_dict, language=R](https://conbench.arrow-dev.org/compare/benchmarks/06a51510ac0073a28000ca2946995c7d...06a549516a47789680001a9a37f2ca4e)
The [full Conbench report](https://github.com/apache/arrow/runs/87261200111) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50457: [C++][Gandiva] Add LN alias for LOG [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #50458:
URL: https://github.com/apache/arrow/pull/50458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50457 Add LN alias for LOG [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50458:
URL: https://github.com/apache/arrow/pull/50458#issuecomment-4929989371
:warning: GitHub issue #50457 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50457: [C++][Gandiva] Add LN alias for LOG [arrow]
Posted by "a-rafay (via GitHub)" <gi...@apache.org>.
a-rafay commented on PR #50458:
URL: https://github.com/apache/arrow/pull/50458#issuecomment-4936043931
Pretty neat @lriggs. Can we test this before merging (like deploy on daas cluster to and make sure this works in DC like deployment)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org