[jira] [Commented] (CASSANDRA-10368) Support Restricting non-PK Cols in Materialized View Select Statements

["Tyler Hobbs (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384525#comment-15384525 ] 

Tyler Hobbs commented on CASSANDRA-10368:
-----------------------------------------

Hi [~jniebuhr], thanks for the patch!  I've gone back over CASSANDRA-9664 and CASSANDRA-10261 to refresh my memory, and I think you are correct that this is all that we need to do.

However, we do need to add a lot of tests before this can be merged.  The best place to add new tests would be {{test/unit/org/apache/cassandra/cql3/ViewFilteringTest.java}}.

Specifically, we want to test cases like the one in [this comment|https://issues.apache.org/jira/browse/CASSANDRA-9664?focusedCommentId=14724150&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14724150] where we could have potential timestamp issues.  You could also use a couple of test cases in {{test/unit/org/apache/cassandra/cql3/ViewTest.java}} as examples: {{complexTimestampUpdateTest}}, {{testRegularColumnTimestampUpdates}}, and {{testOldTimestamps}}.

Let me know if you need assistance with this.

> Support Restricting non-PK Cols in Materialized View Select Statements
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-10368
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10368
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL
>            Reporter: Tyler Hobbs
>            Priority: Minor
>             Fix For: 3.x
>
>         Attachments: 10368-3.8.txt
>
>
> CASSANDRA-9664 allows materialized views to restrict primary key columns in the select statement.  Due to CASSANDRA-10261, the patch did not include support for restricting non-PK columns.  Now that the timestamp issue has been resolved, we can add support for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)