You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/30 10:08:07 UTC
[GitHub] [dolphinscheduler] kezhenxu94 commented on issue #12190: [Improvement][SPI] Remove duplicate PropertyUtils
kezhenxu94 commented on issue #12190:
URL: https://github.com/apache/dolphinscheduler/issues/12190#issuecomment-1263374813
> Looks like we will have a cyclic reference if adding `common` dependency into `task-plugin` module:
>
> ```
> [ERROR] [ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.apache.dolphinscheduler:dolphinscheduler-common:dev-SNAPSHOT'}' and 'Vertex{label='org.apache.dolphinscheduler:dolphinscheduler-task-api:dev-SNAPSHOT'}' introduces to cycle in the graph org.apache.dolphinscheduler:dolphinscheduler-task-api:dev-SNAPSHOT --> org.apache.dolphinscheduler:dolphinscheduler-common:dev-SNAPSHOT --> org.apache.dolphinscheduler:dolphinscheduler-task-api:dev-SNAPSHOT @
> [ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.apache.dolphinscheduler:dolphinscheduler-common:dev-SNAPSHOT'}' and 'Vertex{label='org.apache.dolphinscheduler:dolphinscheduler-task-api:dev-SNAPSHOT'}' introduces to cycle in the graph org.apache.dolphinscheduler:dolphinscheduler-task-api:dev-SNAPSHOT --> org.apache.dolphinscheduler:dolphinscheduler-common:dev-SNAPSHOT --> org.apache.dolphinscheduler:dolphinscheduler-task-api:dev-SNAPSHOT -> [Help 1]
> ```
>
> 
>
> @kezhenxu94 @ruanwenjun @caishunfeng @SbloodyS May I ask whether there are any graceful solutions to this? Thanks
No, it's a really bad idea to work around this even if there is a solution. There is no reason the common module should depend on the task module, anything inside common module that uses task module should be moved to task-api module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org