You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/11/19 02:43:17 UTC
[james-project] 15/43: [Refactoring] Fix some Java access modifiers
with JUnit 5 in mailbox backup module
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit d300dd401c612aad538b420f8f2748ecec5b489d
Author: Rene Cordier <rc...@linagora.com>
AuthorDate: Fri Nov 15 11:01:21 2019 +0700
[Refactoring] Fix some Java access modifiers with JUnit 5 in mailbox backup module
---
.../mailbox/backup/DefaultMailboxBackupTest.java | 3 +-
.../apache/james/mailbox/backup/DirectoryTest.java | 2 +-
.../james/mailbox/backup/FlagExtraFieldTest.java | 4 +-
.../mailbox/backup/InternalDateExtraFieldTest.java | 5 ++-
.../mailbox/backup/MailboxIdExtraFieldTest.java | 4 +-
.../mailbox/backup/MessageIdExtraFieldTest.java | 4 +-
.../james/mailbox/backup/SizeExtraFieldTest.java | 5 ++-
.../james/mailbox/backup/UidExtraFieldTest.java | 5 ++-
.../mailbox/backup/UidValidityExtraFieldTest.java | 5 ++-
.../mailbox/backup/ZipArchivesLoaderTest.java | 2 +-
.../apache/james/mailbox/backup/ZipAssertTest.java | 44 +++++++++++-----------
.../mailbox/backup/ZipEntryTypeExtraFieldTest.java | 3 +-
12 files changed, 46 insertions(+), 40 deletions(-)
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/DefaultMailboxBackupTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/DefaultMailboxBackupTest.java
index ba7869c..cf6e666 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/DefaultMailboxBackupTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/DefaultMailboxBackupTest.java
@@ -41,11 +41,12 @@ import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import com.github.fge.lambdas.Throwing;
+
import reactor.core.publisher.Mono;
class DefaultMailboxBackupTest implements MailboxMessageFixture {
private static final int BUFFER_SIZE = 4096;
- public static final String EXPECTED_ANNOTATIONS_DIR = "annotations";
+ private static final String EXPECTED_ANNOTATIONS_DIR = "annotations";
private final ArchiveService archiveService = new Zipper();
private final MailArchivesLoader archiveLoader = new ZipArchivesLoader();
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/DirectoryTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/DirectoryTest.java
index 01620e2..dc3d69b 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/DirectoryTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/DirectoryTest.java
@@ -22,7 +22,7 @@ import static org.assertj.core.api.Assertions.assertThat;
import org.junit.jupiter.api.Test;
-public class DirectoryTest {
+class DirectoryTest {
@Test
void isDirectoryShouldReturnTrue() {
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/FlagExtraFieldTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/FlagExtraFieldTest.java
index 9b88762..6f7158a 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/FlagExtraFieldTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/FlagExtraFieldTest.java
@@ -37,10 +37,10 @@ import com.google.common.base.Charsets;
import nl.jqno.equalsverifier.EqualsVerifier;
import nl.jqno.equalsverifier.Warning;
-public class FlagExtraFieldTest {
+class FlagExtraFieldTest {
@Test
- public void shouldMatchBeanContract() {
+ void shouldMatchBeanContract() {
EqualsVerifier.forClass(FlagsExtraField.class)
.suppress(Warning.NONFINAL_FIELDS)
.verify();
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/InternalDateExtraFieldTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/InternalDateExtraFieldTest.java
index c46aaeb..969883b 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/InternalDateExtraFieldTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/InternalDateExtraFieldTest.java
@@ -33,10 +33,11 @@ import org.junit.jupiter.api.Test;
import com.google.common.base.Charsets;
import com.google.common.primitives.Bytes;
+
import nl.jqno.equalsverifier.EqualsVerifier;
import nl.jqno.equalsverifier.Warning;
-public class InternalDateExtraFieldTest {
+class InternalDateExtraFieldTest {
private static final byte[] ZERO_AS_BYTE_ARRAY = {0, 0, 0, 0, 0, 0, 0, 0};
private static final byte[] _123456789ABCDEF0_AS_LE_BYTE_ARRAY = new byte[] {(byte) 0xF0, (byte) 0xDE, (byte) 0xBC, (byte) 0x9A, 0x78, 0x56, 0x34, 0x12};
private static final byte[] FEDCBA9876543210_AS_LE_BYTE_ARRAY = new byte[] {0x10, 0x32, 0x54, 0x76, (byte) 0x98, (byte) 0xBA, (byte) 0xDC, (byte) 0xFE};
@@ -47,7 +48,7 @@ public class InternalDateExtraFieldTest {
private static final Date DEFAULT_DATE = new Date(DEFAULT_DATE_TIMESTAMP);
@Test
- public void shouldMatchBeanContract() {
+ void shouldMatchBeanContract() {
EqualsVerifier.forClass(InternalDateExtraField.class)
.suppress(Warning.NONFINAL_FIELDS)
.verify();
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/MailboxIdExtraFieldTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/MailboxIdExtraFieldTest.java
index 160c356..9f171a3 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/MailboxIdExtraFieldTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/MailboxIdExtraFieldTest.java
@@ -35,14 +35,14 @@ import com.google.common.base.Charsets;
import nl.jqno.equalsverifier.EqualsVerifier;
import nl.jqno.equalsverifier.Warning;
-public class MailboxIdExtraFieldTest {
+class MailboxIdExtraFieldTest {
private static final String DEFAULT_MAILBOX_ID = "123456789ABCDEF0";
private static final byte[] DEFAULT_MAILBOX_ID_BYTE_ARRAY = new byte[] {0x31, 0x32, 0x33, 0x34, 0x35, 0x36, 0x37, 0x38, 0x39, 0x41, 0x42, 0x43, 0x44, 0x45, 0x46, 0x30};
private static final byte [] EMPTY_BYTE_ARRAY = {};
@Test
- public void shouldMatchBeanContract() {
+ void shouldMatchBeanContract() {
EqualsVerifier.forClass(MailboxIdExtraField.class)
.suppress(Warning.NONFINAL_FIELDS)
.verify();
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/MessageIdExtraFieldTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/MessageIdExtraFieldTest.java
index 758dff6..3103ae5 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/MessageIdExtraFieldTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/MessageIdExtraFieldTest.java
@@ -35,14 +35,14 @@ import com.google.common.base.Charsets;
import nl.jqno.equalsverifier.EqualsVerifier;
import nl.jqno.equalsverifier.Warning;
-public class MessageIdExtraFieldTest {
+class MessageIdExtraFieldTest {
private static final String DEFAULT_MESSAGE_ID = "123456789ABCDEF0";
private static final byte[] DEFAULT_MESSAGE_ID_BYTE_ARRAY = new byte[] {0x31, 0x32, 0x33, 0x34, 0x35, 0x36, 0x37, 0x38, 0x39, 0x41, 0x42, 0x43, 0x44, 0x45, 0x46, 0x30};
private static final byte [] EMPTY_BYTE_ARRAY = {};
@Test
- public void shouldMatchBeanContract() {
+ void shouldMatchBeanContract() {
EqualsVerifier.forClass(MessageIdExtraField.class)
.suppress(Warning.NONFINAL_FIELDS)
.verify();
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/SizeExtraFieldTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/SizeExtraFieldTest.java
index 0062183..8c01c52 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/SizeExtraFieldTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/SizeExtraFieldTest.java
@@ -31,10 +31,11 @@ import org.junit.jupiter.api.Test;
import com.google.common.base.Charsets;
import com.google.common.primitives.Bytes;
+
import nl.jqno.equalsverifier.EqualsVerifier;
import nl.jqno.equalsverifier.Warning;
-public class SizeExtraFieldTest {
+class SizeExtraFieldTest {
private static final byte[] ZERO_AS_BYTE_ARRAY = {0, 0, 0, 0, 0, 0, 0, 0};
private static final byte[] _123456789ABCDEF0_AS_LE_BYTE_ARRAY = new byte[] {(byte) 0xF0, (byte) 0xDE, (byte) 0xBC, (byte) 0x9A, 0x78, 0x56, 0x34, 0x12};
private static final byte[] FEDCBA9876543210_AS_LE_BYTE_ARRAY = new byte[] {0x10, 0x32, 0x54, 0x76, (byte) 0x98, (byte) 0xBA, (byte) 0xDC, (byte) 0xFE};
@@ -48,7 +49,7 @@ public class SizeExtraFieldTest {
}
@Test
- public void shouldMatchBeanContract() {
+ void shouldMatchBeanContract() {
EqualsVerifier.forClass(SizeExtraField.class)
.suppress(Warning.NONFINAL_FIELDS)
.verify();
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/UidExtraFieldTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/UidExtraFieldTest.java
index 646c711..8d0137b 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/UidExtraFieldTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/UidExtraFieldTest.java
@@ -32,17 +32,18 @@ import org.junit.jupiter.api.Test;
import com.google.common.base.Charsets;
import com.google.common.primitives.Bytes;
+
import nl.jqno.equalsverifier.EqualsVerifier;
import nl.jqno.equalsverifier.Warning;
-public class UidExtraFieldTest {
+class UidExtraFieldTest {
private static final byte[] ZERO_AS_BYTE_ARRAY = {0, 0, 0, 0, 0, 0, 0, 0};
private static final byte[] _123456789ABCDEF0_AS_LE_BYTE_ARRAY = new byte[] {(byte) 0xF0, (byte) 0xDE, (byte) 0xBC, (byte) 0x9A, 0x78, 0x56, 0x34, 0x12};
private static final byte[] FEDCBA9876543210_AS_LE_BYTE_ARRAY = new byte[] {0x10, 0x32, 0x54, 0x76, (byte) 0x98, (byte) 0xBA, (byte) 0xDC, (byte) 0xFE};
private static final byte[] UNUSED = new byte[] {(byte) 0xDE, (byte) 0xAD};
@Test
- public void shouldMatchBeanContract() {
+ void shouldMatchBeanContract() {
EqualsVerifier.forClass(UidExtraField.class)
.suppress(Warning.NONFINAL_FIELDS)
.verify();
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/UidValidityExtraFieldTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/UidValidityExtraFieldTest.java
index 60d3c58..b707321 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/UidValidityExtraFieldTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/UidValidityExtraFieldTest.java
@@ -32,17 +32,18 @@ import org.junit.jupiter.api.Test;
import com.google.common.base.Charsets;
import com.google.common.primitives.Bytes;
+
import nl.jqno.equalsverifier.EqualsVerifier;
import nl.jqno.equalsverifier.Warning;
-public class UidValidityExtraFieldTest {
+class UidValidityExtraFieldTest {
private static final byte[] ZERO_AS_BYTE_ARRAY = {0, 0, 0, 0, 0, 0, 0, 0};
private static final byte[] _123456789ABCDEF0_AS_LE_BYTE_ARRAY = new byte[] {(byte) 0xF0, (byte) 0xDE, (byte) 0xBC, (byte) 0x9A, 0x78, 0x56, 0x34, 0x12};
private static final byte[] FEDCBA9876543210_AS_LE_BYTE_ARRAY = new byte[] {0x10, 0x32, 0x54, 0x76, (byte) 0x98, (byte) 0xBA, (byte) 0xDC, (byte) 0xFE};
private static final byte[] UNUSED = new byte[] {(byte) 0xDE, (byte) 0xAD};
@Test
- public void shouldMatchBeanContract() {
+ void shouldMatchBeanContract() {
EqualsVerifier.forClass(UidValidityExtraField.class)
.suppress(Warning.NONFINAL_FIELDS)
.verify();
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipArchivesLoaderTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipArchivesLoaderTest.java
index 8ac762f..13b7f74 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipArchivesLoaderTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipArchivesLoaderTest.java
@@ -41,7 +41,7 @@ import org.junit.jupiter.api.Test;
import com.github.fge.lambdas.Throwing;
-public class ZipArchivesLoaderTest implements MailboxMessageFixture {
+class ZipArchivesLoaderTest implements MailboxMessageFixture {
private static final int BUFFER_SIZE = 4096;
private final ArchiveService archiveService = new Zipper();
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipAssertTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipAssertTest.java
index d8b1b84..a30da30 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipAssertTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipAssertTest.java
@@ -50,7 +50,7 @@ import org.junit.jupiter.api.extension.ExtendWith;
import com.google.common.collect.ImmutableList;
@ExtendWith(TemporaryFolderExtension.class)
-public class ZipAssertTest {
+class ZipAssertTest {
static class ZipEntryWithContent {
@@ -158,7 +158,7 @@ public class ZipAssertTest {
}
@Test
- public void hasNoEntryShouldNotThrowWhenEmpty() throws Exception {
+ void hasNoEntryShouldNotThrowWhenEmpty() throws Exception {
try (ZipFile zipFile = buildZipFile()) {
assertThatCode(() -> assertThatZip(zipFile)
.hasNoEntry())
@@ -167,7 +167,7 @@ public class ZipAssertTest {
}
@Test
- public void hasNoEntryShouldThrowWhenNotEmpty() throws Exception {
+ void hasNoEntryShouldThrowWhenNotEmpty() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY)) {
assertThatThrownBy(() -> assertThatZip(zipFile)
.hasNoEntry())
@@ -176,7 +176,7 @@ public class ZipAssertTest {
}
@Test
- public void containsOnlyEntriesMatchingShouldNotThrowWhenBothEmpty() throws Exception {
+ void containsOnlyEntriesMatchingShouldNotThrowWhenBothEmpty() throws Exception {
try (ZipFile zipFile = buildZipFile()) {
assertThatCode(() -> assertThatZip(zipFile)
.containsOnlyEntriesMatching())
@@ -185,7 +185,7 @@ public class ZipAssertTest {
}
@Test
- public void containsOnlyEntriesMatchingShouldNotThrowWhenRightOrder() throws Exception {
+ void containsOnlyEntriesMatchingShouldNotThrowWhenRightOrder() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY, ENTRY_2)) {
assertThatCode(() -> assertThatZip(zipFile)
.containsOnlyEntriesMatching(
@@ -196,7 +196,7 @@ public class ZipAssertTest {
}
@Test
- public void hasNameShouldThrowWhenWrongName() throws Exception {
+ void hasNameShouldThrowWhenWrongName() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY)) {
assertThatThrownBy(() -> assertThatZip(zipFile)
.containsOnlyEntriesMatching(
@@ -206,7 +206,7 @@ public class ZipAssertTest {
}
@Test
- public void isDirectoryShouldThrowWhenNotADirectory() throws Exception {
+ void isDirectoryShouldThrowWhenNotADirectory() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY)) {
assertThatThrownBy(() -> assertThatZip(zipFile)
.containsOnlyEntriesMatching(
@@ -217,7 +217,7 @@ public class ZipAssertTest {
}
@Test
- public void isDirectoryShouldNotThrowWhenDirectory() throws Exception {
+ void isDirectoryShouldNotThrowWhenDirectory() throws Exception {
try (ZipArchiveOutputStream archiveOutputStream = new ZipArchiveOutputStream(destination)) {
ZipArchiveEntry archiveEntry = (ZipArchiveEntry) archiveOutputStream.createArchiveEntry(new Directory("any"), DIRECTORY_NAME);
@@ -236,7 +236,7 @@ public class ZipAssertTest {
}
@Test
- public void containsOnlyEntriesMatchingShouldNotThrowWhenWrongOrder() throws Exception {
+ void containsOnlyEntriesMatchingShouldNotThrowWhenWrongOrder() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY, ENTRY_2)) {
assertThatCode(() -> assertThatZip(zipFile)
.containsOnlyEntriesMatching(
@@ -247,7 +247,7 @@ public class ZipAssertTest {
}
@Test
- public void containsOnlyEntriesMatchingShouldThrowWhenExpectingMoreEntries() throws Exception {
+ void containsOnlyEntriesMatchingShouldThrowWhenExpectingMoreEntries() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY, ENTRY_2)) {
assertThatThrownBy(() -> assertThatZip(zipFile)
.containsOnlyEntriesMatching(
@@ -259,7 +259,7 @@ public class ZipAssertTest {
}
@Test
- public void containsOnlyEntriesMatchingShouldThrowWhenExpectingLessEntries() throws Exception {
+ void containsOnlyEntriesMatchingShouldThrowWhenExpectingLessEntries() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY, ENTRY_2)) {
assertThatThrownBy(() -> assertThatZip(zipFile)
.containsOnlyEntriesMatching(
@@ -269,7 +269,7 @@ public class ZipAssertTest {
}
@Test
- public void containsExactlyEntriesMatchingShouldNotThrowWhenBothEmpty() throws Exception {
+ void containsExactlyEntriesMatchingShouldNotThrowWhenBothEmpty() throws Exception {
try (ZipFile zipFile = buildZipFile()) {
assertThatCode(() -> assertThatZip(zipFile)
.containsExactlyEntriesMatching())
@@ -278,7 +278,7 @@ public class ZipAssertTest {
}
@Test
- public void containsExactlyEntriesMatchingShouldThrowWhenWrongOrder() throws Exception {
+ void containsExactlyEntriesMatchingShouldThrowWhenWrongOrder() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY, ENTRY_2)) {
assertThatThrownBy(() -> assertThatZip(zipFile)
.containsExactlyEntriesMatching(
@@ -288,7 +288,7 @@ public class ZipAssertTest {
}
}
@Test
- public void containsExactlyEntriesMatchingShouldNotThrowWhenRightOrder() throws Exception {
+ void containsExactlyEntriesMatchingShouldNotThrowWhenRightOrder() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY, ENTRY_2)) {
assertThatCode(() -> assertThatZip(zipFile)
.containsExactlyEntriesMatching(
@@ -299,7 +299,7 @@ public class ZipAssertTest {
}
@Test
- public void containsExactlyEntriesMatchingShouldThrowWhenExpectingMoreEntries() throws Exception {
+ void containsExactlyEntriesMatchingShouldThrowWhenExpectingMoreEntries() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY, ENTRY_2)) {
assertThatThrownBy(() -> assertThatZip(zipFile)
.containsExactlyEntriesMatching(
@@ -311,7 +311,7 @@ public class ZipAssertTest {
}
@Test
- public void containsExactlyEntriesMatchingShouldThrowWhenExpectingLessEntries() throws Exception {
+ void containsExactlyEntriesMatchingShouldThrowWhenExpectingLessEntries() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY, ENTRY_2)) {
assertThatThrownBy(() -> assertThatZip(zipFile)
.containsExactlyEntriesMatching(
@@ -321,7 +321,7 @@ public class ZipAssertTest {
}
@Test
- public void hasStringContentShouldNotThrowWhenIdentical() throws Exception {
+ void hasStringContentShouldNotThrowWhenIdentical() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY)) {
assertThatCode(() -> assertThatZip(zipFile)
.containsOnlyEntriesMatching(
@@ -332,7 +332,7 @@ public class ZipAssertTest {
}
@Test
- public void hasStringContentShouldThrowWhenDifferent() throws Exception {
+ void hasStringContentShouldThrowWhenDifferent() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY)) {
assertThatThrownBy(() -> assertThatZip(zipFile)
.containsOnlyEntriesMatching(
@@ -343,7 +343,7 @@ public class ZipAssertTest {
}
@Test
- public void containsOnlyExtraFieldsShouldNotThrowWhenBothEmpty() throws Exception {
+ void containsOnlyExtraFieldsShouldNotThrowWhenBothEmpty() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY)) {
assertThatCode(() -> assertThatZip(zipFile)
.containsOnlyEntriesMatching(
@@ -354,7 +354,7 @@ public class ZipAssertTest {
}
@Test
- public void containsOnlyExtraFieldsShouldThrowWhenMissingExpectedField() throws Exception {
+ void containsOnlyExtraFieldsShouldThrowWhenMissingExpectedField() throws Exception {
try (ZipFile zipFile = buildZipFile(ENTRY)) {
assertThatThrownBy(() -> assertThatZip(zipFile)
.containsOnlyEntriesMatching(
@@ -365,7 +365,7 @@ public class ZipAssertTest {
}
@Test
- public void containsOnlyExtraFieldsShouldNotThrowWhenUnexpectedField() throws Exception {
+ void containsOnlyExtraFieldsShouldNotThrowWhenUnexpectedField() throws Exception {
try (ZipArchiveOutputStream archiveOutputStream = new ZipArchiveOutputStream(destination)) {
ZipArchiveEntry archiveEntry = (ZipArchiveEntry) archiveOutputStream.createArchiveEntry(new File("any"), ENTRY_NAME);
@@ -387,7 +387,7 @@ public class ZipAssertTest {
}
@Test
- public void containsOnlyExtraFieldsShouldNotThrowWhenContainingExpectedExtraFields() throws Exception {
+ void containsOnlyExtraFieldsShouldNotThrowWhenContainingExpectedExtraFields() throws Exception {
try (ZipArchiveOutputStream archiveOutputStream = new ZipArchiveOutputStream(destination)) {
ZipArchiveEntry archiveEntry = (ZipArchiveEntry) archiveOutputStream.createArchiveEntry(new File("any"), ENTRY_NAME);
diff --git a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipEntryTypeExtraFieldTest.java b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipEntryTypeExtraFieldTest.java
index 87d886f..59dfe5f 100644
--- a/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipEntryTypeExtraFieldTest.java
+++ b/mailbox/backup/src/test/java/org/apache/james/mailbox/backup/ZipEntryTypeExtraFieldTest.java
@@ -32,10 +32,11 @@ import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import com.google.common.base.Charsets;
+
import nl.jqno.equalsverifier.EqualsVerifier;
import nl.jqno.equalsverifier.Warning;
-public class ZipEntryTypeExtraFieldTest {
+class ZipEntryTypeExtraFieldTest {
private static final byte[] ZERO_AS_BYTE_ARRAY = {0, 0, 0, 0, 0, 0, 0, 0};
private static final byte[] ONE_AS_BYTE_ARRAY = {1, 0, 0, 0, 0, 0, 0, 0};
private static final byte[] TWO_AS_BYTE_ARRAY = {2, 0, 0, 0, 0, 0, 0, 0};
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org