You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/08/26 20:43:16 UTC

[GitHub] [trafficserver] randall opened a new pull request #8285: Cleanup generated LDFLAGS for jemalloc

randall opened a new pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285


   Use the already expanded jemalloc_ldflags instead of overwriting what
   was previously specified earlier in the file.
   
   Also, drop use --add-needed,--no-as-needed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] bneradt removed a comment on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-908498688


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] duke8253 commented on a change in pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
duke8253 commented on a change in pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#discussion_r698784599



##########
File path: build/jemalloc.m4
##########
@@ -56,7 +56,7 @@ if test "$enable_jemalloc" != "no"; then
   if test "$jemalloc_base_dir" != "/usr"; then
     TS_ADDTO(CPPFLAGS, [-I${jemalloc_include}])
     TS_ADDTO(LDFLAGS, [-L${jemalloc_ldflags}])

Review comment:
       Should we remove this line then? Looks like a duplicate




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall commented on a change in pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
randall commented on a change in pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#discussion_r698806581



##########
File path: build/jemalloc.m4
##########
@@ -56,7 +56,7 @@ if test "$enable_jemalloc" != "no"; then
   if test "$jemalloc_base_dir" != "/usr"; then
     TS_ADDTO(CPPFLAGS, [-I${jemalloc_include}])
     TS_ADDTO(LDFLAGS, [-L${jemalloc_ldflags}])

Review comment:
       good catch! 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] zwoop commented on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-911985458


   Cherry-picked to v9.1.x branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall commented on a change in pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
randall commented on a change in pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#discussion_r698806581



##########
File path: build/jemalloc.m4
##########
@@ -56,7 +56,7 @@ if test "$enable_jemalloc" != "no"; then
   if test "$jemalloc_base_dir" != "/usr"; then
     TS_ADDTO(CPPFLAGS, [-I${jemalloc_include}])
     TS_ADDTO(LDFLAGS, [-L${jemalloc_ldflags}])

Review comment:
       good catch! 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] bneradt removed a comment on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-908498688


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall removed a comment on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-908535393


   [approve ci autest]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich commented on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-907249482


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] bneradt commented on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-908498688


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich removed a comment on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
shinrich removed a comment on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-907249482


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall removed a comment on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-908535393


   [approve ci autest]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall merged pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
randall merged pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall commented on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-908535393


   [approve ci autest]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich removed a comment on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
shinrich removed a comment on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-907249482


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall merged pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
randall merged pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] duke8253 commented on a change in pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
duke8253 commented on a change in pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#discussion_r698784599



##########
File path: build/jemalloc.m4
##########
@@ -56,7 +56,7 @@ if test "$enable_jemalloc" != "no"; then
   if test "$jemalloc_base_dir" != "/usr"; then
     TS_ADDTO(CPPFLAGS, [-I${jemalloc_include}])
     TS_ADDTO(LDFLAGS, [-L${jemalloc_ldflags}])

Review comment:
       Should we remove this line then? Looks like a duplicate




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] bneradt commented on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-908498688


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] randall commented on pull request #8285: Cleanup generated LDFLAGS for jemalloc

Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8285:
URL: https://github.com/apache/trafficserver/pull/8285#issuecomment-908535393


   [approve ci autest]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org