You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/06/22 03:09:24 UTC

Review Request: FLUME-1917. File Channel group commit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12047/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Moved the sync out of the commit calls and make those calls explicitly. sync() method will fsync only if the last commit position is higher than the last sync position.


This addresses bug FLUME-1917.
    https://issues.apache.org/jira/browse/FLUME-1917


Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8dc0ff8 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java bb8ce1a 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogFile.java 4da6ac1 

Diff: https://reviews.apache.org/r/12047/diff/


Testing
-------

Added a new unit test. All current tests pass


Thanks,

Hari Shreedharan