[GitHub] [druid] jihoonson commented on a change in pull request #12012: Make NodeRole available during binding; add support for dynamic registration of DruidService

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #12012:
URL: https://github.com/apache/druid/pull/12012#discussion_r761551705



##########
File path: extensions-contrib/materialized-view-maintenance/src/main/java/org/apache/druid/indexing/materializedview/MaterializedViewMaintenanceDruidModule.java
##########
@@ -25,10 +25,12 @@
 import com.google.common.collect.ImmutableList;
 import com.google.inject.Binder;
 import org.apache.druid.guice.JsonConfigProvider;
+import org.apache.druid.guice.annotations.LoadOn;
 import org.apache.druid.initialization.DruidModule;
 
 import java.util.List;
 
+@LoadOn(roles = "overlord")

Review comment:
       I renamed the annotation to `LoadScope`. Let me know if that makes more sense. For people who have fat-fingers like myself, I added constants in `NodeRole` that can be used here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org