You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by "Zhanwei Wang (JIRA)" <ji...@apache.org> on 2016/03/14 03:30:33 UTC

[jira] [Commented] (HAWQ-523) dead code in executormgr_bind_executor_task()

    [ https://issues.apache.org/jira/browse/HAWQ-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192670#comment-15192670 ] 

Zhanwei Wang commented on HAWQ-523:
-----------------------------------

Hi [~wcl14]

Nice catch


> dead code in executormgr_bind_executor_task()
> ---------------------------------------------
>
>                 Key: HAWQ-523
>                 URL: https://issues.apache.org/jira/browse/HAWQ-523
>             Project: Apache HAWQ
>          Issue Type: New Feature
>          Components: Dispatcher
>    Affects Versions: 2.0.0
>            Reporter: Chunling Wang
>            Assignee: Lei Chang
>
> In executormgr.c, the code below would never access:
> bool
> executormgr_bind_executor_task(struct DispatchData *data,
> 							QueryExecutor *executor,
> 							SegmentDatabaseDescriptor *desc,
> 							struct DispatchTask *task,
> 							struct DispatchSlice *slice)
> {
> 	...
> 	if (desc == NULL)
> 	{
> 		executor->health = QEH_ERROR;
> 		return false;
> 	}
> 	...
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)