You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "tmedicci (via GitHub)" <gi...@apache.org> on 2024/10/23 12:35:27 UTC
[PR] boards/esp32s3: Merge MCUboot and "simple-boot" linker scripts [nuttx]
tmedicci opened a new pull request, #14481:
URL: https://github.com/apache/nuttx/pull/14481
## Summary
* boards/esp32s3: Merge MCUboot and "simple-boot" linker scripts
To make it easier to keep the linker scripts updated for both MCUboot and "simple-boot", this commit merges them into a single linker script with macros to enable/disable specific sections.
## Impact
Fix https://github.com/apache/nuttx/issues/12490 and make it easier to keep the linker scripts updated for both bootloaders.
## Testing
Internal CI testing + ESP32-S3-DevKitC-1 v1.0: `esp32s3-devkit:sta_softap` with `CONFIG_ESPRESSIF_SIMPLE_BOOT=y` (simple-boot, the default bootloader) and with `CONFIG_ESP32S3_APP_FORMAT_MCUBOOT=y` (MCUboot).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/esp32s3: Merge MCUboot and "simple-boot" linker scripts [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #14481:
URL: https://github.com/apache/nuttx/pull/14481#issuecomment-2432040854
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
The PR summary is missing some details about the functional part of the code being changed and how the change exactly works. It only mentions what and why but not how.
The Impact section is not properly filled. It only mentions a related issue it fixes but fails to address most of the impact points with a YES/NO answer and description.
The Testing section lacks details about the build host and provides no testing logs.
Therefore, **this PR does not meet the NuttX requirements**. It needs more details in the Summary, a completely filled Impact section, and additional information in the Testing section to be compliant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/esp32s3: Merge MCUboot and "simple-boot" linker scripts [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14481:
URL: https://github.com/apache/nuttx/pull/14481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org