You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by beriaanirudh <gi...@git.apache.org> on 2017/01/19 14:54:00 UTC
[GitHub] zeppelin pull request #1914: [ZEPPELIN-1983] Feedback about success/failure ...
GitHub user beriaanirudh opened a pull request:
https://github.com/apache/zeppelin/pull/1914
[ZEPPELIN-1983] Feedback about success/failure when interpreter is re\u2026
### What is this PR for?
When a interpreter is restarted, there is no feedback to user whether the action is received/honoured by zeppelin. This might also lead them to click restart multiple times, before they realize it has taken affect.
Also fixed a null bug.
### What type of PR is it?
[Improvement + Bug fix]
### Todos
* None
### What is the Jira issue?
ZEPPELIN-1983
### How should this be tested?
Restart a interpreter to test the positive case. The message should disappers on its own after sometime if not closed. A simple way to test the negative case is to stop the server and then try restarting.
### Screenshots (if appropriate)
#### Positive case
#### Negative case
### Questions:
* Does the licenses files need update?
-No
* Is there breaking changes for older versions?
-No
* Does this needs documentation?
-No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/beriaanirudh/zeppelin ZEPPELIN-1983
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1914.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1914
----
commit 761b986ef649fcd00a02e938d108b50c21118c42
Author: Beria <be...@qubole.com>
Date: 2016-05-06T04:32:02Z
[ZEPPELIN-1983] Feedback about success/failure when interpreter is restarted
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1914: [ZEPPELIN-1983] Feedback about success/failure when in...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1914
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1914: [ZEPPELIN-1983] Feedback about success/failure when in...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1914
Will merge it into master and branch-0.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1914: [ZEPPELIN-1983] Feedback about success/failure ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1914
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1914: [ZEPPELIN-1983] Feedback about success/failure when in...
Posted by beriaanirudh <gi...@git.apache.org>.
Github user beriaanirudh commented on the issue:
https://github.com/apache/zeppelin/pull/1914
Thanks for the review @jongyoul . I looked at the CI failure and it looks irrelevant to this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---