You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ascheman (via GitHub)" <gi...@apache.org> on 2025/05/25 14:03:33 UTC
[PR] Add Plexus .github [maven-sources]
ascheman opened a new pull request, #21:
URL: https://github.com/apache/maven-sources/pull/21
as it is used in Plexus project and therefore nice to have it at hand when working on GH workflows.
Note, this replaces #18 (partially)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Plexus .github [maven-sources]
Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman commented on PR #21:
URL: https://github.com/apache/maven-sources/pull/21#issuecomment-5103465090
Closing in favour of #49, which supersedes this PR.
#21 was raised from a fork I no longer have write access to and can therefore no longer be updated. #49 is rebased onto current `master` and addresses @hboutemy's review — the local checkout path is renamed from `.github` to the visible `github` (commit 43cd665).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Plexus .github [maven-sources]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #21:
URL: https://github.com/apache/maven-sources/pull/21#discussion_r2106222710
##########
default.xml:
##########
@@ -146,6 +146,7 @@
<project path='svn/doxia-ide' name='maven-doxia-ide.git' revision='trunk' />
<project path='plexus/codehaus-plexus.github.io' name='codehaus-plexus.github.io.git' remote='plexus' revision='source' />
+ <project path='plexus/.github' name='.github.git' remote='plexus' />
Review Comment:
can we call it `github` instead of `.github` in the directory tree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Plexus .github [maven-sources]
Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman commented on code in PR #21:
URL: https://github.com/apache/maven-sources/pull/21#discussion_r3665048711
##########
default.xml:
##########
@@ -146,6 +146,7 @@
<project path='svn/doxia-ide' name='maven-doxia-ide.git' revision='trunk' />
<project path='plexus/codehaus-plexus.github.io' name='codehaus-plexus.github.io.git' remote='plexus' revision='source' />
+ <project path='plexus/.github' name='.github.git' remote='plexus' />
Review Comment:
Resolved in the follow-up PR #49: I went with your suggestion and renamed the local checkout path from `.github` to the visible `github` (commit 43cd665). I had to open #49 because I lost write access to the fork backing this PR, so #21 could no longer be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Plexus .github [maven-sources]
Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman commented on code in PR #21:
URL: https://github.com/apache/maven-sources/pull/21#discussion_r2106242382
##########
default.xml:
##########
@@ -146,6 +146,7 @@
<project path='svn/doxia-ide' name='maven-doxia-ide.git' revision='trunk' />
<project path='plexus/codehaus-plexus.github.io' name='codehaus-plexus.github.io.git' remote='plexus' revision='source' />
+ <project path='plexus/.github' name='.github.git' remote='plexus' />
Review Comment:
I was thinking about `dot.github` (have seen that on other repositories to make it visible). What's your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Plexus .github [maven-sources]
Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman closed pull request #21: Add Plexus .github
URL: https://github.com/apache/maven-sources/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org