You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Luis Arias <lu...@elysia.com> on 1999/11/20 10:33:01 UTC
PATCH : ant DesirableFilter includes CVS Base subdirectory
Hello,
Found this while trying to do a simple item from the ant TODO list. I am
using WinCvs1.1b7 and not always connected to the internet. In this case,
when issuing a CVS edit, WinCvs1.1b7 places a copy of the old version in the
CVS/Base directory. So when building ant I was getting these files
compiled. Is this the right way to issue a patch ?
cvs diff DesirableFilter.java (in directory
C:\Java\jakarta-tools\ant\src\main\org\apache\tools\ant\)
cvs diff: warning: unrecognized response `cvs: setgroups: Operation not
permitted' from cvs server
Index: DesirableFilter.java
===================================================================
RCS file:
/home/cvspublic/jakarta-tools/ant/src/main/org/apache/tools/ant/DesirableFil
ter.java,v
retrieving revision 1.1
diff -r1.1 DesirableFilter.java
67a68,73
> // cvs file - Ran into this using WinCvs1.1b7
> if (dir.getName().equalsIgnoreCase("CVS") &&
> name.equalsIgnoreCase("base")) {
> return false;
> }
>
Re: PATCH : ant DesirableFilter includes CVS Base subdirectory
Posted by Luis Arias <lu...@elysia.com>.
----- Original Message -----
From: James Duncan Davidson <ja...@eng.sun.com>
To: <to...@jakarta.apache.org>
Sent: Saturday, November 20, 1999 7:58 PM
Subject: Re: PATCH : ant DesirableFilter includes CVS Base subdirectory
>
> > Found this while trying to do a simple item from the ant TODO list. I
am
> > using WinCvs1.1b7 and not always connected to the internet. In this
case,
> > when issuing a CVS edit, WinCvs1.1b7 places a copy of the old version in
the
> > CVS/Base directory. So when building ant I was getting these files
> > compiled. Is this the right way to issue a patch ?
>
> Interesting. Working from memory, using the "desirability" rules that
> are in place, the recursion shouldn't even enter the CVS directory. It
> seems like a bug in the logic to even try explicitly block items in the
> CVS dir.
>
> So that I can try this out, let me verify that the following is the
> directory structure that you are talking about:
>
> project/
> project/CVS/
> project/CVS/Entries
> project/CVS/Entries.log
> project/CVS/Repository
> project/CVS/Root
> project/CVS/Base/ ))) Added by WinCVS
> project/CVS/Base/* )))
>
Yes that's exactly it. This can take place in any directory in the project.
I was also wondering why the individual CVS entries were treated separately
instead of simply excluding the CVS directory itself. However, since
apparently the filter has multiple uses (not just in compilation) I didn't
want to go into it too much. This would require more investigation.
Concerning the WinCVS behavior, apparently this is part of CVS 1.10.
Re: PATCH : ant DesirableFilter includes CVS Base subdirectory
Posted by James Duncan Davidson <ja...@eng.sun.com>.
> Found this while trying to do a simple item from the ant TODO list. I am
> using WinCvs1.1b7 and not always connected to the internet. In this case,
> when issuing a CVS edit, WinCvs1.1b7 places a copy of the old version in the
> CVS/Base directory. So when building ant I was getting these files
> compiled. Is this the right way to issue a patch ?
Interesting. Working from memory, using the "desirability" rules that
are in place, the recursion shouldn't even enter the CVS directory. It
seems like a bug in the logic to even try explicitly block items in the
CVS dir.
So that I can try this out, let me verify that the following is the
directory structure that you are talking about:
project/
project/CVS/
project/CVS/Entries
project/CVS/Entries.log
project/CVS/Repository
project/CVS/Root
project/CVS/Base/ ))) Added by WinCVS
project/CVS/Base/* )))
.duncan
--
James Davidson duncan@eng.sun.com
Java + XML / Portable Code + Portable Data !try; do()