[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #14466: [MKL-DNN] Enable s8 support for inner product and 3d input with flatten=false

[GitBox <gi...@apache.org>]

ZhennanQin commented on a change in pull request #14466: [MKL-DNN] Enable s8 support for inner product and 3d input with flatten=false
URL: https://github.com/apache/incubator-mxnet/pull/14466#discussion_r266728459
 
 

 ##########
 File path: src/operator/quantization/quantized_fully_connected.cc
 ##########
 @@ -50,11 +50,14 @@ bool QuantizedFullyConnectedShape(const nnvm::NodeAttrs& attrs,
   CHECK(!shape_is_none(in_shape->at(0)))
     << "QuantizedFullyConnectedOp input data shape must be given";
   const mxnet::TShape& dshape = in_shape->at(0);
-  mxnet::TShape wshape = Shape2(param.num_hidden, dshape.ProdShape(1, dshape.ndim()));
-  if (dshape.ndim() != 2) {
-      CHECK(param.flatten)
-        << "QuantizedFullyConnectedOp only supports flatten=true when ishape.ndim()!=2 for now. ";
+  index_t num_input;
+  if (!param.flatten) {
+    num_input = dshape[dshape.ndim()-1];
 
 Review comment:
   Add blank before and after operator.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services