[jira] [Commented] (KAFKA-604) Add missing metrics in 0.8

["Joel Koshy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493656#comment-13493656 ] 

Joel Koshy commented on KAFKA-604:
----------------------------------

Looks good overall. Some initial comments:

KafkaTimer:
I see why you needed to add the Seq-based time method: to update a specific and
a global timer at one shot. However, we should still keep the previous (class)
method because: the new method is slightly clunky to use  (in having to wrap
everything around the function call parentheses). The main goal of that method
was convenience - or the user could directly deal with the timer and its
context. So can you restore that code and just use the new object method where
you need it?

With the above, the following can be reverted:
SimpleConsumer
KafkaController
ReplicaStateMachine
SyncProducer
KafkaTimerTest (although we should additionally exercise your new object
method).

Log.scala:
- Can you break line 488?
                
> Add missing metrics in 0.8
> --------------------------
>
>                 Key: KAFKA-604
>                 URL: https://issues.apache.org/jira/browse/KAFKA-604
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>         Attachments: kafka_604_v1.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> It would be good if we add the following metrics:
> Producer: droppedMessageRate per topic
> ReplicaManager: partition count on the broker
> FileMessageSet: logFlushTimer per log (i.e., partition). Also, logFlushTime should probably be moved to LogSegment since the flush now includes index flush time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira