[GitHub] [ozone] xichen01 commented on pull request #4939: HDDS-8888. Consider Datanode queue capacity when sending DeleteBlocks command

["xichen01 (via GitHub)" <gi...@apache.org>]

xichen01 commented on PR #4939:
URL: https://github.com/apache/ozone/pull/4939#issuecomment-1733429052

   
   > //...
   > 
   > Case: if DN command queue previoulsy is "0" or less than 5 and also DN is down, this will cause to add same command at SCM till limit "5". (duplicating exactly till 5 overall).
   >//...
   
   Thank you for your reply.
   
   Yes, currently, if the DN is down, duplicate commands are put to the SCM command queue until the limit.
   
   However, if the HDDS-8882 is merged, the SCM will not place duplicate commands into the SCM command queue, because if a command is not sent to the DN, the command status will be `TO_BE_SENT` and the `TO_BE_SENT` command will be skipped when the SCM generating a `DeletedBlocksTransaction` command.
   
   So if the HDDS-8882 is also merged, while the DN is down, the SCM will generate **unduplicated** `DeletedBlocksTransaction` commands to the command queue.
   
   
   > May be we can check for lesser queue size at SCM to send like limit "2" to avoid duplicate for the change.
   
   If HDDS-8882 can be merged, maybe this doesn't need to be added
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org