You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "machi1990 (via GitHub)" <gi...@apache.org> on 2023/04/21 13:12:10 UTC
[GitHub] [kafka-site] machi1990 opened a new pull request, #504: KAFKA-10883: link to get started in the top navigation header
machi1990 opened a new pull request, #504:
URL: https://github.com/apache/kafka-site/pull/504
Closes https://issues.apache.org/jira/browse/KAFKA-10883
Hi @mimaison can you've a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] mimaison commented on pull request #504: KAFKA-10883: link to get started in the top navigation header
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #504:
URL: https://github.com/apache/kafka-site/pull/504#issuecomment-1517955010
Yes feel free to edit the JIRA. I've granted you permissions so you should be able to self assign tickets if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] mimaison commented on pull request #504: KAFKA-10883: link to get started in the top navigation header
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #504:
URL: https://github.com/apache/kafka-site/pull/504#issuecomment-1517838156
Hi @machi1990, thanks for the PR!
I agree that the behavior of the menu is a bit strange. The issue is that the "get started" page does not seem finished, so I wonder if it's the reason it's currently not reachable.
For example, it says "All you need to know to get up and running with Apache Kafka can be found here. **Etc. Etc.**". Also the buttons don't seem to work.
So before enabling it, I think we should properly finish it. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] machi1990 commented on pull request #504: KAFKA-10883: link to get started in the top navigation header
Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on PR #504:
URL: https://github.com/apache/kafka-site/pull/504#issuecomment-1517993660
Thanks @mimaison I've edited the JIRA to capture what has been discussed here. I'll close this PR as it is also mentioned in the JIRA that once the page is redisigned/finished off it has to be linked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] machi1990 closed pull request #504: KAFKA-10883: link to get started in the top navigation header
Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 closed pull request #504: KAFKA-10883: link to get started in the top navigation header
URL: https://github.com/apache/kafka-site/pull/504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka-site] machi1990 commented on pull request #504: KAFKA-10883: link to get started in the top navigation header
Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on PR #504:
URL: https://github.com/apache/kafka-site/pull/504#issuecomment-1517920328
Hi @mimaison thanks for the review. You are right. I landed on this issue when I was trying to understand how the website is generated. I didn't appreciate that the other buttons don't work: when I navigated to the `/get-started` link and seeing the "Introduction" content, I wrongly assumed that all worked fine and we could quickly add the link and have the quick win. However, it seems that the "get-started" page hasn't been revisited since https://github.com/apache/kafka-site/pull/269 and it has always been the case that's it's not linked in the top navigation menu. I wonder if there are plans to rework the content, @scott-confluent any thoughts ?
> So before enabling it, I think we should properly finish it. WDYT?
I'd agree, thanks. In this case, I think the JIRA https://issues.apache.org/jira/browse/KAFKA-10883 could be edited in the way it reflects this sentiment i.e the page needs to be properly finished and then linked in the top navigation menu. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org