[GitHub] sijie commented on a change in pull request #3486: [pulsar-broker] separate broker-client config to allow-insecure-cnx for broker replication

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #3486: [pulsar-broker] separate broker-client config to allow-insecure-cnx for broker replication
URL: https://github.com/apache/pulsar/pull/3486#discussion_r252499003
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 ##########
 @@ -563,7 +563,7 @@ public PulsarClient getReplicationClient(String cluster) {
                                     : data.getServiceUrlTls())
                             .enableTls(true)
                             .tlsTrustCertsFilePath(pulsar.getConfiguration().getBrokerClientTrustCertsFilePath())
-                            .allowTlsInsecureConnection(pulsar.getConfiguration().isTlsAllowInsecureConnection());
+                            .allowTlsInsecureConnection(pulsar.getConfiguration().isBrokerClientTlsAllowInsecureConnection());
 
 Review comment:
   for backward compatibility consideration, shall we implement `isBrokerClientTlsAllowInsecureConnection()`?
   
   basically if brokerClientTlsAllowInsecureConnection is not provided, use tlsAllowInsecureConnection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services