[GitHub] [incubator-superset] john-bodley commented on a change in pull request #8512: Disable deprecated druid connector by default

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #8512: Disable deprecated druid connector by default
URL: https://github.com/apache/incubator-superset/pull/8512#discussion_r351481205
 
 

 ##########
 File path: superset/config.py
 ##########
 @@ -170,10 +170,15 @@ def _try_json_readsha(filepath):
 # [TimeZone List]
 # See: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
 # other tz can be overridden by providing a local_config
-DRUID_IS_ACTIVE = True
 DRUID_TZ = tz.tzutc()
 DRUID_ANALYSIS_TYPES = ["cardinality"]
 
+# Legacy Druid connector
+# Druid supports a SQL interface in its newer versions.
+# Setting this flag to True enables the deprecated, API-based Druid
+# connector. This feature may be removed at a future date.
+DRUID_IS_ACTIVE = False
 
 Review comment:
   @willbarret apologies for not mentioning this sooner but can we rename this to something more specific, i.e., `DRUID_NATIVE_IS_ACTIVE` or `DRUID_NOSQL_IS_ACTIVE`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org