[GitHub] [superset] Antonio-RiveroMartnez commented on pull request #20627: fix(chart): Time Series set showMaxLabel as null for time xAxis

["Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>]

Antonio-RiveroMartnez commented on PR #20627:
URL: https://github.com/apache/superset/pull/20627#issuecomment-1437789662

   Hey @villebro , thanks for the catch 🙌 , I'm more than happy reverting the changes if they are causing issues.
   
   `showMaxLabel: null` means ECharts automatically determine whether or not the label should display, while setting it to `true` would force the label to show all the time. For time series, it's set to `false` by default, that's why we tried to bypass such wrong behavior by setting it to `null` and rely on such `auto` computation.
   
   Now, I might be wrong, but finding a new approach might get us to address the issue directly on ECharts, since it is the one in charge for how to render such labels.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org