You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/28 23:10:41 UTC

[GitHub] [beam] alexbeltran opened a new issue, #22089: [Bug]: Firestore Connector can have empty cursors resulting in an incorrect success

alexbeltran opened a new issue, #22089:
URL: https://github.com/apache/beam/issues/22089

   ### What happened?
   
   Reproduction Steps:
   1. Have a sufficiently large RunQuery that times out
   2. Run query
   3. The Connector terminates after timeout but returns a success.
   
   This is likely due to, https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreV1ReadFn.java#L426 which uses a last received value to get a start point. There is no error check so the last received value may be empty. From there an empty cursor is created.
   
   ### Issue Priority
   
   Priority: 2
   
   ### Issue Component
   
   Component: io-java-gcp


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj commented on issue #22089: [Bug]: Firestore Connector can have empty cursors resulting in an incorrect success

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on issue #22089:
URL: https://github.com/apache/beam/issues/22089#issuecomment-1185908044

   Fixed by https://github.com/apache/beam/pull/22175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj closed issue #22089: [Bug]: Firestore Connector can have empty cursors resulting in an incorrect success

Posted by GitBox <gi...@apache.org>.
chamikaramj closed issue #22089: [Bug]: Firestore Connector can have empty cursors resulting in an incorrect success
URL: https://github.com/apache/beam/issues/22089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org