You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/08 07:04:04 UTC

[GitHub] [spark] zheniantoushipashi commented on a diff in pull request #37427: [SPARK-39929][SQL] DS V2 supports push down string functions(non ANSI)

zheniantoushipashi commented on code in PR #37427:
URL: https://github.com/apache/spark/pull/37427#discussion_r939887502


##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -154,6 +154,18 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with ExplainSuiteHel
       conn.prepareStatement("INSERT INTO \"test\".\"dept\" VALUES (1, 1)").executeUpdate()
       conn.prepareStatement("INSERT INTO \"test\".\"dept\" VALUES (2, 1)").executeUpdate()
 
+
+      conn.prepareStatement(
+        "CREATE TABLE \"test\".\"employee1\" (dept INTEGER, name TEXT(32), " +

Review Comment:
   done  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org