You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/03 20:52:05 UTC

[GitHub] [incubator-druid] gianm commented on a change in pull request #7591: Remove SQL experimental banner and other doc adjustments.

gianm commented on a change in pull request #7591: Remove SQL experimental banner and other doc adjustments.
URL: https://github.com/apache/incubator-druid/pull/7591#discussion_r280925271
 
 

 ##########
 File path: docs/content/toc.md
 ##########
 @@ -164,10 +165,8 @@ layout: toc
   * Experimental Features
     * [Overview](/docs/VERSION/development/experimental.html)
     * [Approximate Histograms and Quantiles](/docs/VERSION/development/extensions-core/approximate-histograms.html)
-    * [Datasketches](/docs/VERSION/development/extensions-core/datasketches-extension.html)
     * [Geographic Queries](/docs/VERSION/development/geo.html)
     * [Router](/docs/VERSION/development/router.html)
-    * [Kafka Indexing Service](/docs/VERSION/development/extensions-core/kafka-ingestion.html)
 
 Review comment:
   KIS is already in the ingestion section.
   
   DataSketches isn't in the ToC but it's described in the approximate algorithms and sql sections.
   
   Actually, now that I think about this a bit more, I think removing the entire experimental feature section is a good idea. There is no particular reason to have them displayed so prominently. It is better for them to be in the sections that make sense for them (node type, aggregator, whatever).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org