You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/09/02 12:48:04 UTC
[GitHub] [mynewt-nimble] tluio opened a new issue #858: Possible NULL dereference in porting/nimble/src/os_mempool.c
tluio opened a new issue #858:
URL: https://github.com/apache/mynewt-nimble/issues/858
On line 81, the pointer **membuf** is checked in
if (membuf != NULL)
This indicates that **membuf** can be NULL.
If so, a NULL dereference bug will occur on line 114:
SLIST_NEXT(block_ptr, mb_next)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski closed issue #858: Possible NULL dereference in porting/nimble/src/os_mempool.c
Posted by GitBox <gi...@apache.org>.
KKopyscinski closed issue #858:
URL: https://github.com/apache/mynewt-nimble/issues/858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on issue #858: Possible NULL dereference in porting/nimble/src/os_mempool.c
Posted by GitBox <gi...@apache.org>.
KKopyscinski commented on issue #858:
URL: https://github.com/apache/mynewt-nimble/issues/858#issuecomment-844863427
Fixed in merged patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on issue #858: Possible NULL dereference in porting/nimble/src/os_mempool.c
Posted by GitBox <gi...@apache.org>.
sjanc commented on issue #858:
URL: https://github.com/apache/mynewt-nimble/issues/858#issuecomment-694696675
Looks like this was already fixed in core but nimble copy wasn't updated. We should probably sync copy with core
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on issue #858: Possible NULL dereference in porting/nimble/src/os_mempool.c
Posted by GitBox <gi...@apache.org>.
sjanc commented on issue #858:
URL: https://github.com/apache/mynewt-nimble/issues/858#issuecomment-687106427
if membuf is NULL, blocks must be 0 (otherwise function returns in line 81) so that while() never loops and thus SLIST_NEXT(block_ptr, mb_next) is not called
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] tluio commented on issue #858: Possible NULL dereference in porting/nimble/src/os_mempool.c
Posted by GitBox <gi...@apache.org>.
tluio commented on issue #858:
URL: https://github.com/apache/mynewt-nimble/issues/858#issuecomment-687115468
Sorry, but I wonder if our code is the same? If **blocks** is 0, SLIST_NEXT(block_ptr, mb_next) is also called in line 114.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org