[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1223: MINIFICPP-1223 Only reload script file in ExecutePythonScript when requested in property

[GitBox <gi...@apache.org>]

lordgamez commented on a change in pull request #1223:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1223#discussion_r762864051



##########
File path: PROCESSORS.md
##########
@@ -421,8 +421,9 @@ In the list below, the names of required properties appear in bold. Any other pr
 
 | Name | Default Value | Allowable Values | Description |
 | - | - | - | - |
-|Script File|||Path to script file to execute. Only one of Script File or Script Body may be used|
+|**Reload on Script Change**|false||If true and Script File property is used, then script file will be reloaded if it has changed, otherwise the first loaded version will be used at all times.|

Review comment:
       My only concern was the backward compatibility especially for native python processors as previously even though it looked like we reloaded the script actually it was never reloaded. But on second thought I don't think it would be a problem and we still haven't released version 1.0 so I updated it in 3a8c9b43245739352f3fef8602dac1592f0eafdd




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org