You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by ka...@apache.org on 2020/06/08 12:07:17 UTC
[fineract] branch develop updated: FINERACT-822 enable JdkObsolete
error
This is an automated email from the ASF dual-hosted git repository.
kaze pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 731079e FINERACT-822 enable JdkObsolete error
731079e is described below
commit 731079ede78aca86e553499331e009cf2659c151
Author: percyashu <pe...@gmail.com>
AuthorDate: Sun Jun 7 22:45:40 2020 +0100
FINERACT-822 enable JdkObsolete error
---
fineract-provider/build.gradle | 3 +--
.../org/apache/fineract/accounting/glaccount/domain/GLAccount.java | 6 +++---
.../java/org/apache/fineract/organisation/office/domain/Office.java | 4 ++--
.../main/java/org/apache/fineract/portfolio/group/domain/Group.java | 3 +--
4 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/fineract-provider/build.gradle b/fineract-provider/build.gradle
index ae224cc..56b5521 100644
--- a/fineract-provider/build.gradle
+++ b/fineract-provider/build.gradle
@@ -307,7 +307,6 @@ tasks.withType(JavaCompile) {
"UnusedVariable",
"InconsistentCapitalization",
"ClassCanBeStatic",
- "OperatorPrecedence",
"MixedMutabilityReturnType",
"SameNameButDifferent",
"ReferenceEquality",
@@ -325,7 +324,6 @@ tasks.withType(JavaCompile) {
"DoubleBraceInitialization",
"UnusedNestedClass",
"UndefinedEquals",
- "JdkObsolete",
)
//TODO gradually enable these checks
error(
@@ -368,6 +366,7 @@ tasks.withType(JavaCompile) {
"MissingCasesInEnumSwitch",
"OperatorPrecedence",
"EqualsGetClass",
+ "JdkObsolete",
// "ReturnMissingNullable",
// "InconsistentOverloads",
// "MethodCanBeStatic",
diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccount.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccount.java
index 5407645..bf82b1d 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccount.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccount.java
@@ -18,8 +18,8 @@
*/
package org.apache.fineract.accounting.glaccount.domain;
+import java.util.ArrayList;
import java.util.LinkedHashMap;
-import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import javax.persistence.Column;
@@ -50,7 +50,7 @@ public class GLAccount extends AbstractPersistableCustom {
@OneToMany(fetch = FetchType.LAZY)
@JoinColumn(name = "parent_id")
- private List<GLAccount> children = new LinkedList<>();
+ private List<GLAccount> children = new ArrayList<>();
@Column(name = "name", nullable = false, length = 45)
private String name;
@@ -245,4 +245,4 @@ public class GLAccount extends AbstractPersistableCustom {
this.parent = parentAccount;
generateHierarchy();
}
-}
\ No newline at end of file
+}
diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/office/domain/Office.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/office/domain/Office.java
index ddf49fc..65b2feb 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/organisation/office/domain/Office.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/office/domain/Office.java
@@ -19,9 +19,9 @@
package org.apache.fineract.organisation.office.domain;
import java.io.Serializable;
+import java.util.ArrayList;
import java.util.Date;
import java.util.LinkedHashMap;
-import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import javax.persistence.Column;
@@ -48,7 +48,7 @@ public class Office extends AbstractPersistableCustom implements Serializable {
@OneToMany(fetch = FetchType.LAZY)
@JoinColumn(name = "parent_id")
- private List<Office> children = new LinkedList<>();
+ private List<Office> children = new ArrayList<>();
@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn(name = "parent_id")
diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java
index 92f0769..bea4f61 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java
@@ -22,7 +22,6 @@ import java.util.ArrayList;
import java.util.Date;
import java.util.HashSet;
import java.util.LinkedHashMap;
-import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.Set;
@@ -107,7 +106,7 @@ public final class Group extends AbstractPersistableCustom {
@OneToMany(fetch = FetchType.EAGER)
@JoinColumn(name = "parent_id")
- private List<Group> groupMembers = new LinkedList<>();
+ private List<Group> groupMembers = new ArrayList<>();
@ManyToMany
@JoinTable(name = "m_group_client", joinColumns = @JoinColumn(name = "group_id"), inverseJoinColumns = @JoinColumn(name = "client_id"))