You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/17 05:46:52 UTC

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #4112: [Bug] Fix bug that tablet meta lock twice

caiconghui commented on a change in pull request #4112:
URL: https://github.com/apache/incubator-doris/pull/4112#discussion_r456230960



##########
File path: be/src/olap/tablet.h
##########
@@ -222,6 +222,8 @@ class Tablet : public BaseTablet {
     void build_tablet_report_info(TTabletInfo* tablet_info);
 
     void generate_tablet_meta_copy(TabletMetaSharedPtr new_tablet_meta) const;
+    // caller should hold the _meta_load before calling this method

Review comment:
       ```suggestion
       // caller should hold the _meta_lock before calling this method
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org