You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/08/09 07:42:33 UTC

[GitHub] zeppelin pull request #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/1307

    ZEPPELIN-1311. Typo in ZEPPELIN-1197

    ### What is this PR for?
    My bad, it should be `Exception` rather than `Execution`
    
    ![2016-08-09_1528](https://cloud.githubusercontent.com/assets/164491/17508482/aab4fe8c-5e47-11e6-9e26-1295b76cd43b.png)
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1311
    
    ### How should this be tested?
    Tested manually. 
    
    ### Screenshots (if appropriate)
    Here's the new log after this fix.
    ![image](https://cloud.githubusercontent.com/assets/164491/17508506/c5798ca6-5e47-11e6-9f91-e827116dcf38.png)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1311

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1307
    
----
commit 710857322b09e5adb918edd3e7f39a70a1598a24
Author: Jeff Zhang <zj...@apache.org>
Date:   2016-08-09T07:38:25Z

    ZEPPELIN-1311. Typo in ZEPPELIN-1197

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:

    https://github.com/apache/zeppelin/pull/1307
  
    @zjffdu While I am merging this guy, I realized that this fix is not applicable to branch-0.6 since #1232 is only merged to master. For me, #1232 seems more like improvement than bug fix. It would be nice if we can provide same feature for python interpreter at the same release for user experience consistency. I am suggesting to keep #1232, #1307 only master and provide it in next release. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1307
  
    Done, now it would print the full stack stace
    ![image](https://cloud.githubusercontent.com/assets/164491/17511496/a024fc3e-5e55-11e6-87cd-7b2ab75bb280.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1307


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:

    https://github.com/apache/zeppelin/pull/1307
  
    @zjffdu let me merge it as hotfix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1307
  
    \cc @Leemoonsoo @minahlee Is it possible to merge it into 0.6.1 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1307
  
    oh, sorry, I didn't realize `ZEPPELIN-1197` is not in 0.6. Then let's merge this to master only. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1307
  
    @minahlee  Please hold the commit, I will have another improvement soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1307
  
    Looks great to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1307
  
    Thanks @minahlee, the CI fail should be irrelevant, it is due to network issue.
    ```
    [INFO] \u2514\u2500\u2500 semver-utils@1.1.1
    [ERROR] npm ERR! Linux 3.13.0-40-generic
    [ERROR] npm ERR! argv "/home/travis/build/apache/zeppelin/zeppelin-web/node/node" "/home/travis/build/apache/zeppelin/zeppelin-web/node/node_modules/npm/bin/npm-cli.js" "install" "--color=false"
    [ERROR] npm ERR! node v0.12.13
    [ERROR] npm ERR! npm  v2.15.0
    [ERROR] 
    [ERROR] npm ERR! Callback called more than once.
    [ERROR] npm ERR! 
    [ERROR] npm ERR! If you need help, you may report this error at:
    [ERROR] npm ERR!     <https://github.com/npm/npm/issues>
    [ERROR] 
    [ERROR] npm ERR! Please include the following file with any support request:
    [ERROR] npm ERR!     /home/travis/build/apache/zeppelin/zeppelin-web/npm-debug.log
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1307: ZEPPELIN-1311. Typo in ZEPPELIN-1197

Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:

    https://github.com/apache/zeppelin/pull/1307
  
    Change looks good to me. Merging to master and branch-0.6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---