You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by agresch <gi...@git.apache.org> on 2018/05/15 20:07:40 UTC
[GitHub] storm pull request #2677: STORM-3075 fix NPE
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2677
STORM-3075 fix NPE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agresch/storm agresch_storm-3075
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2677.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2677
----
commit 6a3150edef5ea58ddd8218df91e2b93ad9f90cd3
Author: Aaron Gresch <ag...@...>
Date: 2018-05-15T20:06:53Z
STORM-3075 fix NPE
----
---
[GitHub] storm issue #2677: STORM-3075 fix NPE
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2677
@Ethanlm - done. Added a spelling fix.
---
[GitHub] storm pull request #2677: STORM-3075 fix NPE
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2677
---
[GitHub] storm issue #2677: STORM-3075 fix NPE
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2677
It looks reasonable. But would like to understand more about it. Could you elaborate on in which case tc will be null?
---
[GitHub] storm issue #2677: STORM-3075 fix NPE
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2677
There might be a bug in the code: https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L490-L497
```
if (leaderElector == null) {
leaderElector = Zookeeper.zkLeaderElector(conf, zkClient, blobStore, topoCache, stormClusterState, getNimbusAcls(conf));
}
this.leaderElector = leaderElector;
this.blobStore.setLeaderElector(this.leaderElector);
if (topoCache == null) {
topoCache = new TopoCache(blobStore, conf);
}
```
`topoCache` initialization should happen before `leaderElector`
---
[GitHub] storm issue #2677: STORM-3075 fix NPE
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2677
@Ethanlm - I see tc being null whenever I start nimbus (at least with no topologies).
---
[GitHub] storm issue #2677: STORM-3075 fix NPE
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2677
@Ethanlm - please take a look. Thanks.
---
[GitHub] storm issue #2677: STORM-3075 fix NPE
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2677
@agresch you can squash the commits and then I can merge it in.
---
[GitHub] storm issue #2677: STORM-3075 fix NPE
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2677
@Ethanlm - nice catch. Will fix the source of the problem instead....
---