[jira] [Commented] (JCLOUDS-492) In the registerUnixImageBackedByEbsInRegion (Amazon), the root device name is being hardcoded to /dev/sda1 in the interface as form parameters. This has to be configurable by user.

["Jaiganesh Mathaiyan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCLOUDS-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925036#comment-13925036 ] 

Jaiganesh Mathaiyan commented on JCLOUDS-492:
---------------------------------------------

Working on a fix for this. See comments below from Ignasi for fixing this issue.

Hi Jai,

I would remove the hardcoded value and add a method to the options class to
configure it, but since the options is a varargs, it could be ommited and
the root device undefined.

I think a good approach would be removing the options parameter from the
existing method and create a new one with the options object not being a
varargs (making it mandatory). This way you could add the new method to
configure the root device in the options object (and default to the current
one).

This keeps the current behavior but does not allow to pass N option
parameters, which makes no sense. I think the varargs was there to make the
parameter optional, but that's not the right way to do that :)

WDYT?

Thanks for your interest!

> In the registerUnixImageBackedByEbsInRegion (Amazon), the root device name is being hardcoded to /dev/sda1 in the interface as form parameters. This has to be configurable by user.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JCLOUDS-492
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-492
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-compute
>    Affects Versions: 1.7.1
>            Reporter: Jaiganesh Mathaiyan
>            Priority: Minor
>             Fix For: 1.7.2
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)