You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/08 17:14:20 UTC

[GitHub] [flink] beyond1920 opened a new pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

beyond1920 opened a new pull request #17205:
URL: https://github.com/apache/flink/pull/17205


   ## What is the purpose of the change
   
   This pr aims to update `MATCH_ROWTIME` function. After update, `MATCH_ROWTIME` function could receive no operand or one operand which is a field reference with row time attribute. If there is no operand, the function returns row time attribute with TIMESTAMP. Else, return type is same with operand type.
   
   ## Brief change log
   
     - Add `MatchRowTimeFunction` class to do operand checker and return type inference.
     - Update `FlinkSqlOperatorTable` to use `MatchRowTimeFunction`
     - Add validate in `FlinkLogicalMatch` to check `MATCH_ROWTIME()` could only be used when input stream does not contain row time attribute with TIMESTAMP_LTZ type.
     - Simplify `RelTimeIndicatorConverter` because it does not need to take `MATCH_ROWTIME()` type infer and propagation into consideration.
   
   ## Verifying this change
   
     - Add UT in `MatchRecognizeTest`
     - Fix wrong results of ITCase: `MatchRecognizeITCase#testWindowedGroupingAppliedToMatchRecognizeOnLtzRowtime` 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240",
       "triggerID" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c8ea9552f00c97efc8cbb3e19fa23b89b8c69772 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181) 
   * 5e5c83a827211b9a5d8337d58bcf352c7fc37a4f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240) 
   * cdf36a2de30c3f50128af2ec881cd65b66b00bfa UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 170096fc6b1f13b86f5ceecfad89f8bf61b16181 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123) 
   * c8ea9552f00c97efc8cbb3e19fa23b89b8c69772 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 911c37bbcc7b9ec9603ae72bede52bc2b464642c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 911c37bbcc7b9ec9603ae72bede52bc2b464642c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240",
       "triggerID" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c8ea9552f00c97efc8cbb3e19fa23b89b8c69772 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181) 
   * 5e5c83a827211b9a5d8337d58bcf352c7fc37a4f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] beyond1920 commented on a change in pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #17205:
URL: https://github.com/apache/flink/pull/17205#discussion_r708810575



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/MatchRowTimeFunction.java
##########
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.sql;
+
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlFunction;
+import org.apache.calcite.sql.SqlFunctionCategory;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperandCountRange;
+import org.apache.calcite.sql.SqlOperatorBinding;
+import org.apache.calcite.sql.type.SqlOperandCountRanges;
+
+import java.util.List;
+
+/**
+ * Function used to access an row time attribute with TIMESTAMP or TIMESTAMP_LTZ type from
+ * MATCH_RECOGNIZE. The function could receive no operand or one operand which is a field reference
+ * with row time attribute. If there is no operand, the function returns row time attribute with
+ * TIMESTAMP. Else, return type is same with operand type.
+ */
+public class MatchRowTimeFunction extends SqlFunction {
+
+    /** Creates a window table function with a given name. */
+    public MatchRowTimeFunction() {
+        super(
+                "MATCH_ROWTIME",
+                SqlKind.OTHER_FUNCTION,
+                null,
+                null,
+                null,

Review comment:
       Do you mean return type inference or operand type inference?
   If you mean return type inference, I have overwriten the `inferReturnType` method. I thought it could achieve same goals. Please correct me if I'm wrong.
   If you mean operand type inference, I have overwriten the `checkOperandTypes` to check the operand.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 911c37bbcc7b9ec9603ae72bede52bc2b464642c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799) 
   * 7e524508a999c88c22e981f9ec8a6fcdc6cb07bf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] leonardBang commented on a change in pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #17205:
URL: https://github.com/apache/flink/pull/17205#discussion_r707457704



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/MatchRowTimeFunction.java
##########
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.sql;
+
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlFunction;
+import org.apache.calcite.sql.SqlFunctionCategory;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperandCountRange;
+import org.apache.calcite.sql.SqlOperatorBinding;
+import org.apache.calcite.sql.type.SqlOperandCountRanges;
+
+import java.util.List;
+
+/**
+ * Function used to access an row time attribute with TIMESTAMP or TIMESTAMP_LTZ type from
+ * MATCH_RECOGNIZE. The function could receive no operand or one operand which is a field reference
+ * with row time attribute. If there is no operand, the function returns row time attribute with
+ * TIMESTAMP. Else, return type is same with operand type.

Review comment:
       ```suggestion
    * The function used to access a rowtime attribute with TIMESTAMP or TIMESTAMP_LTZ type from
    * MATCH_RECOGNIZE clause. The function accepts zero or one operand which is a field reference
    * with rowtime attribute. If there is no operand, the function will return rowtime attribute with
    * TIMESTAMP type. Otherwise, the return type will be same with the operand type.
   ```

##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/MatchRowTimeFunction.java
##########
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.sql;
+
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlFunction;
+import org.apache.calcite.sql.SqlFunctionCategory;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperandCountRange;
+import org.apache.calcite.sql.SqlOperatorBinding;
+import org.apache.calcite.sql.type.SqlOperandCountRanges;
+
+import java.util.List;
+
+/**
+ * Function used to access an row time attribute with TIMESTAMP or TIMESTAMP_LTZ type from
+ * MATCH_RECOGNIZE. The function could receive no operand or one operand which is a field reference
+ * with row time attribute. If there is no operand, the function returns row time attribute with
+ * TIMESTAMP. Else, return type is same with operand type.
+ */
+public class MatchRowTimeFunction extends SqlFunction {
+
+    /** Creates a window table function with a given name. */
+    public MatchRowTimeFunction() {
+        super(
+                "MATCH_ROWTIME",
+                SqlKind.OTHER_FUNCTION,
+                null,
+                null,
+                null,
+                SqlFunctionCategory.MATCH_RECOGNIZE);
+    }
+
+    @Override
+    public String getAllowedSignatures(String opNameToUse) {
+        return "MATCH_ROWTIME([time attribute field])";
+    }
+
+    @Override
+    public SqlOperandCountRange getOperandCountRange() {
+        return SqlOperandCountRanges.between(0, 1);
+    }
+
+    public String getSignatureTemplate(final int operandsCount) {
+        switch (operandsCount) {
+            case 0:
+                return "{}";
+            case 1:
+                return "{0})";
+            default:
+                throw new AssertionError();
+        }
+    }
+
+    @Override
+    public boolean checkOperandTypes(SqlCallBinding callBinding, boolean throwOnFailure) {
+        List<SqlNode> operands = callBinding.operands();
+        int n = operands.size();
+        assert n == 0 || n == 1;
+        if (n == 0) {
+            return true;
+        } else {
+            SqlNode operand = callBinding.operand(0);
+            if (operand.getKind() != SqlKind.IDENTIFIER) {
+                if (throwOnFailure) {
+                    ValidationException exception =
+                            new ValidationException(
+                                    String.format(
+                                            "The function %s requires argument to be a field reference, but is '%s'.",

Review comment:
       ```suggestion
                                               "The function %s requires a field reference as argument, but actual argument is '%s'.",
   ```

##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalMatch.scala
##########
@@ -65,6 +70,28 @@ class FlinkLogicalMatch(
     interval)
   with FlinkLogicalRel {
 
+  override def isValid(litmus: Litmus, context: RelNode.Context): Boolean = {
+    val inputContainsRowTimeLtz = input.getRowType.getFieldList.exists { field =>
+      isRowtimeIndicatorType(field.getType) &&
+        field.getType.getSqlTypeName == SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE
+    }
+    if (inputContainsRowTimeLtz) {
+      val containMatchRowTimeWithoutArgs = getMeasures.values().exists(
+        MatchUtil.isFinalOnMatchRowTimeWithoutArgs)
+      if (containMatchRowTimeWithoutArgs) {
+        litmus.fail(
+          "MATCH_ROWTIME() could only be used when input stream does not contain " +
+            "row time attribute with TIMESTAMP_LTZ type.\n" +
+            "Please pass rowtime attribute field as input argument of MATCH_ROWTIME function.")

Review comment:
       ```suggestion
             "MATCH_ROWTIME(rowtimeField) should be used when input stream contains " +
               "rowtime attribute with TIMESTAMP_LTZ type.\n" +
               "Please pass rowtime attribute field as input argument of MATCH_ROWTIME(rowtimeField) function.")
   ```

##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/MatchRowTimeFunction.java
##########
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.sql;
+
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlFunction;
+import org.apache.calcite.sql.SqlFunctionCategory;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperandCountRange;
+import org.apache.calcite.sql.SqlOperatorBinding;
+import org.apache.calcite.sql.type.SqlOperandCountRanges;
+
+import java.util.List;
+
+/**
+ * Function used to access an row time attribute with TIMESTAMP or TIMESTAMP_LTZ type from
+ * MATCH_RECOGNIZE. The function could receive no operand or one operand which is a field reference
+ * with row time attribute. If there is no operand, the function returns row time attribute with
+ * TIMESTAMP. Else, return type is same with operand type.
+ */
+public class MatchRowTimeFunction extends SqlFunction {
+
+    /** Creates a window table function with a given name. */
+    public MatchRowTimeFunction() {
+        super(
+                "MATCH_ROWTIME",
+                SqlKind.OTHER_FUNCTION,
+                null,
+                null,
+                null,
+                SqlFunctionCategory.MATCH_RECOGNIZE);
+    }
+
+    @Override
+    public String getAllowedSignatures(String opNameToUse) {
+        return "MATCH_ROWTIME([time attribute field])";
+    }
+
+    @Override
+    public SqlOperandCountRange getOperandCountRange() {
+        return SqlOperandCountRanges.between(0, 1);
+    }
+
+    public String getSignatureTemplate(final int operandsCount) {
+        switch (operandsCount) {
+            case 0:
+                return "{}";
+            case 1:
+                return "{0})";
+            default:
+                throw new AssertionError();
+        }
+    }
+
+    @Override
+    public boolean checkOperandTypes(SqlCallBinding callBinding, boolean throwOnFailure) {
+        List<SqlNode> operands = callBinding.operands();
+        int n = operands.size();
+        assert n == 0 || n == 1;
+        if (n == 0) {
+            return true;
+        } else {
+            SqlNode operand = callBinding.operand(0);
+            if (operand.getKind() != SqlKind.IDENTIFIER) {
+                if (throwOnFailure) {
+                    ValidationException exception =
+                            new ValidationException(
+                                    String.format(
+                                            "The function %s requires argument to be a field reference, but is '%s'.",
+                                            callBinding.getOperator().getName(),
+                                            operand.getKind()));
+                    throw exception;
+                } else {
+                    return false;
+                }
+            }
+            RelDataType operandType = callBinding.getOperandType(0);
+            if (FlinkTypeFactory.isRowtimeIndicatorType(operandType)) {
+                return true;
+            } else {
+                if (throwOnFailure) {
+                    ValidationException exception =
+                            new ValidationException(
+                                    String.format(
+                                            "The function %s requires argument to be a row time attribute type, but is '%s'.",
+                                            callBinding.getOperator().getName(), operandType));
+                    throw exception;
+                } else {
+                    return false;
+                }
+            }
+        }
+    }
+
+    @Override
+    public RelDataType inferReturnType(SqlOperatorBinding opBinding) {
+        // Returns RowTime if there is no argument

Review comment:
       rowtime

##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/MatchRecognizeTest.scala
##########
@@ -43,6 +44,47 @@ class MatchRecognizeTest extends TableTestBase {
     util.tableEnv.executeSql(ddl)
   }
 
+  @Test
+  def testMatchRecognizeOnRowtime(): Unit = {
+    val ddl =
+      """
+        |CREATE TABLE Ticker1 (
+        | `symbol` STRING,
+        | `ts_ltz` TIMESTAMP(3),

Review comment:
       hint: ts

##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalMatch.scala
##########
@@ -65,6 +70,28 @@ class FlinkLogicalMatch(
     interval)
   with FlinkLogicalRel {
 
+  override def isValid(litmus: Litmus, context: RelNode.Context): Boolean = {
+    val inputContainsRowTimeLtz = input.getRowType.getFieldList.exists { field =>
+      isRowtimeIndicatorType(field.getType) &&
+        field.getType.getSqlTypeName == SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE
+    }

Review comment:
       hint : ` isRowtimeIndicatorType(field.getType) && isTimestampLtzIndicatorType(field.getType)`

##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/MatchRowTimeFunction.java
##########
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.sql;
+
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlFunction;
+import org.apache.calcite.sql.SqlFunctionCategory;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperandCountRange;
+import org.apache.calcite.sql.SqlOperatorBinding;
+import org.apache.calcite.sql.type.SqlOperandCountRanges;
+
+import java.util.List;
+
+/**
+ * Function used to access an row time attribute with TIMESTAMP or TIMESTAMP_LTZ type from
+ * MATCH_RECOGNIZE. The function could receive no operand or one operand which is a field reference
+ * with row time attribute. If there is no operand, the function returns row time attribute with
+ * TIMESTAMP. Else, return type is same with operand type.
+ */
+public class MatchRowTimeFunction extends SqlFunction {
+
+    /** Creates a window table function with a given name. */
+    public MatchRowTimeFunction() {
+        super(
+                "MATCH_ROWTIME",
+                SqlKind.OTHER_FUNCTION,
+                null,
+                null,
+                null,

Review comment:
       please given proper `TypeInference`

##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/MatchRowTimeFunction.java
##########
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.sql;
+
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlFunction;
+import org.apache.calcite.sql.SqlFunctionCategory;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperandCountRange;
+import org.apache.calcite.sql.SqlOperatorBinding;
+import org.apache.calcite.sql.type.SqlOperandCountRanges;
+
+import java.util.List;
+
+/**
+ * Function used to access an row time attribute with TIMESTAMP or TIMESTAMP_LTZ type from
+ * MATCH_RECOGNIZE. The function could receive no operand or one operand which is a field reference
+ * with row time attribute. If there is no operand, the function returns row time attribute with
+ * TIMESTAMP. Else, return type is same with operand type.
+ */
+public class MatchRowTimeFunction extends SqlFunction {
+
+    /** Creates a window table function with a given name. */

Review comment:
       window table function ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] leonardBang commented on a change in pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #17205:
URL: https://github.com/apache/flink/pull/17205#discussion_r708814675



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/MatchRowTimeFunction.java
##########
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.sql;
+
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlFunction;
+import org.apache.calcite.sql.SqlFunctionCategory;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperandCountRange;
+import org.apache.calcite.sql.SqlOperatorBinding;
+import org.apache.calcite.sql.type.SqlOperandCountRanges;
+
+import java.util.List;
+
+/**
+ * Function used to access an row time attribute with TIMESTAMP or TIMESTAMP_LTZ type from
+ * MATCH_RECOGNIZE. The function could receive no operand or one operand which is a field reference
+ * with row time attribute. If there is no operand, the function returns row time attribute with
+ * TIMESTAMP. Else, return type is same with operand type.
+ */
+public class MatchRowTimeFunction extends SqlFunction {
+
+    /** Creates a window table function with a given name. */
+    public MatchRowTimeFunction() {
+        super(
+                "MATCH_ROWTIME",
+                SqlKind.OTHER_FUNCTION,
+                null,
+                null,
+                null,

Review comment:
       I mean the `OperandTypeInference`, but I'm okay that you have also done this in `checkOperandTypes (SqlCallBinding callBinding, boolean throwOnFailure)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915422496


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 57d318d50a389b3303698bcc5a8d24c7ee5c2c17 (Wed Sep 08 17:16:32 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e524508a999c88c22e981f9ec8a6fcdc6cb07bf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807) 
   * 170096fc6b1f13b86f5ceecfad89f8bf61b16181 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe closed pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #17205:
URL: https://github.com/apache/flink/pull/17205


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 911c37bbcc7b9ec9603ae72bede52bc2b464642c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] beyond1920 commented on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-919678226


   Hi @leonardBang Thanks very much for review. I've updated the pr. please have a look, thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240",
       "triggerID" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243",
       "triggerID" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243",
       "triggerID" : "921637414",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * cdf36a2de30c3f50128af2ec881cd65b66b00bfa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e524508a999c88c22e981f9ec8a6fcdc6cb07bf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] beyond1920 commented on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915706498


   cc @twalthr @leonardBang @wuchong @godfreyhe . Please have a look, thanks very much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e524508a999c88c22e981f9ec8a6fcdc6cb07bf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807) 
   * 170096fc6b1f13b86f5ceecfad89f8bf61b16181 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240",
       "triggerID" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243",
       "triggerID" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cdf36a2de30c3f50128af2ec881cd65b66b00bfa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 170096fc6b1f13b86f5ceecfad89f8bf61b16181 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123) 
   * c8ea9552f00c97efc8cbb3e19fa23b89b8c69772 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240",
       "triggerID" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243",
       "triggerID" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243",
       "triggerID" : "921637414",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1d732908701d8d51bf7744e4749d34d60ac68c35",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1d732908701d8d51bf7744e4749d34d60ac68c35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cdf36a2de30c3f50128af2ec881cd65b66b00bfa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243) 
   * 1d732908701d8d51bf7744e4749d34d60ac68c35 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c8ea9552f00c97efc8cbb3e19fa23b89b8c69772 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181) 
   * 5e5c83a827211b9a5d8337d58bcf352c7fc37a4f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c8ea9552f00c97efc8cbb3e19fa23b89b8c69772 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240",
       "triggerID" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243",
       "triggerID" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c8ea9552f00c97efc8cbb3e19fa23b89b8c69772 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181) 
   * 5e5c83a827211b9a5d8337d58bcf352c7fc37a4f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240) 
   * cdf36a2de30c3f50128af2ec881cd65b66b00bfa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] beyond1920 commented on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-920515148


   @flinkbot run travis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] beyond1920 commented on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-921409748


   @godfreyhe Thanks very much for review. I've updated the pr, please have a look. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 911c37bbcc7b9ec9603ae72bede52bc2b464642c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799) 
   * 7e524508a999c88c22e981f9ec8a6fcdc6cb07bf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] beyond1920 commented on a change in pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #17205:
URL: https://github.com/apache/flink/pull/17205#discussion_r708810575



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/MatchRowTimeFunction.java
##########
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.sql;
+
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlFunction;
+import org.apache.calcite.sql.SqlFunctionCategory;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperandCountRange;
+import org.apache.calcite.sql.SqlOperatorBinding;
+import org.apache.calcite.sql.type.SqlOperandCountRanges;
+
+import java.util.List;
+
+/**
+ * Function used to access an row time attribute with TIMESTAMP or TIMESTAMP_LTZ type from
+ * MATCH_RECOGNIZE. The function could receive no operand or one operand which is a field reference
+ * with row time attribute. If there is no operand, the function returns row time attribute with
+ * TIMESTAMP. Else, return type is same with operand type.
+ */
+public class MatchRowTimeFunction extends SqlFunction {
+
+    /** Creates a window table function with a given name. */
+    public MatchRowTimeFunction() {
+        super(
+                "MATCH_ROWTIME",
+                SqlKind.OTHER_FUNCTION,
+                null,
+                null,
+                null,

Review comment:
       Do you say return type inference or operand type inference?
   If you said return type inference, I have overwriten the `inferReturnType` method. I thought it could achieve same goals. Please correct me if I'm wrong.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 170096fc6b1f13b86f5ceecfad89f8bf61b16181 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240",
       "triggerID" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243",
       "triggerID" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "921637414",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * cdf36a2de30c3f50128af2ec881cd65b66b00bfa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] beyond1920 commented on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-921637414


   @flinkbot run travis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 170096fc6b1f13b86f5ceecfad89f8bf61b16181 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240",
       "triggerID" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243",
       "triggerID" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243",
       "triggerID" : "921637414",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1d732908701d8d51bf7744e4749d34d60ac68c35",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24258",
       "triggerID" : "1d732908701d8d51bf7744e4749d34d60ac68c35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cdf36a2de30c3f50128af2ec881cd65b66b00bfa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243) 
   * 1d732908701d8d51bf7744e4749d34d60ac68c35 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24258) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on a change in pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #17205:
URL: https://github.com/apache/flink/pull/17205#discussion_r709827514



##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/MatchRecognizeTest.scala
##########
@@ -109,4 +216,136 @@ class MatchRecognizeTest extends TableTestBase {
          |""".stripMargin
     util.verifyRelPlan(sqlQuery)
   }
+
+  // ----------------------------------------------------------------------------------------
+  // Tests for Illegal use of Match_RowTime
+  // ----------------------------------------------------------------------------------------
+
+  @Test
+  def testMatchRowtimeWithoutArgumentOnRowtimeLTZ(): Unit = {
+    thrown.expectMessage(
+      "MATCH_ROWTIME(rowtimeField) should be used when input stream " +
+        "contains rowtime attribute with TIMESTAMP_LTZ type.\n" +
+        "Please pass rowtime attribute field as input argument of " +
+        "MATCH_ROWTIME(rowtimeField) function.")
+    thrown.expect(classOf[AssertionError])
+
+    val sqlQuery =
+      s"""
+         |SELECT
+         |  symbol,
+         |  SUM(price) as price,
+         |  TUMBLE_ROWTIME(matchRowtime, interval '3' second) as rowTime,
+         |  TUMBLE_START(matchRowtime, interval '3' second) as startTime
+         |FROM Ticker
+         |MATCH_RECOGNIZE (
+         |  PARTITION BY symbol
+         |  ORDER BY ts_ltz
+         |  MEASURES
+         |    A.price as price,
+         |    A.tax as tax,
+         |    MATCH_ROWTIME() as matchRowtime
+         |  ONE ROW PER MATCH
+         |  PATTERN (A)
+         |  DEFINE
+         |    A AS A.price > 0
+         |) AS T
+         |GROUP BY symbol, TUMBLE(matchRowtime, interval '3' second)
+         |""".stripMargin
+    util.verifyRelPlan(sqlQuery)
+  }
+
+  @Test
+  def testMatchRowtimeWithMultipleArgs(): Unit = {
+    thrown.expectMessage("Invalid number of arguments to function 'MATCH_ROWTIME'.")
+    thrown.expect(classOf[ValidationException])
+
+    val sqlQuery =
+      s"""
+         |SELECT
+         |  symbol,
+         |  SUM(price) as price,
+         |  TUMBLE_ROWTIME(matchRowtime, interval '3' second) as rowTime,
+         |  TUMBLE_START(matchRowtime, interval '3' second) as startTime
+         |FROM Ticker
+         |MATCH_RECOGNIZE (
+         |  PARTITION BY symbol
+         |  ORDER BY ts_ltz
+         |  MEASURES
+         |    A.price as price,
+         |    A.tax as tax,
+         |    MATCH_ROWTIME(ts_ltz, price) as matchRowtime
+         |  ONE ROW PER MATCH
+         |  PATTERN (A)
+         |  DEFINE
+         |    A AS A.price > 0
+         |) AS T
+         |GROUP BY symbol, TUMBLE(matchRowtime, interval '3' second)
+         |""".stripMargin
+    util.verifyRelPlan(sqlQuery)
+  }
+
+  @Test
+  def testMatchRowtimeWithNonRowTimeAttributeAsArgs(): Unit = {
+    thrown.expectMessage(
+      "The function MATCH_ROWTIME requires argument to be a row time attribute type, " +
+        "but is 'INTEGER'.")
+    thrown.expect(classOf[ValidationException])
+
+    val sqlQuery =
+      s"""
+         |SELECT
+         |  symbol,
+         |  SUM(price) as price,
+         |  TUMBLE_ROWTIME(matchRowtime, interval '3' second) as rowTime,
+         |  TUMBLE_START(matchRowtime, interval '3' second) as startTime
+         |FROM Ticker
+         |MATCH_RECOGNIZE (
+         |  PARTITION BY symbol
+         |  ORDER BY ts_ltz
+         |  MEASURES
+         |    A.price as price,
+         |    A.tax as tax,
+         |    MATCH_ROWTIME(price) as matchRowtime
+         |  ONE ROW PER MATCH
+         |  PATTERN (A)
+         |  DEFINE
+         |    A AS A.price > 0
+         |) AS T
+         |GROUP BY symbol, TUMBLE(matchRowtime, interval '3' second)
+         |""".stripMargin
+    util.verifyRelPlan(sqlQuery)
+  }
+
+  @Test
+  def testMatchRowtimeWithRexCallAsArg(): Unit = {
+    thrown.expectMessage(
+      "The function MATCH_ROWTIME requires a field reference as argument, " +
+        "but actual argument is 'PLUS'.")

Review comment:
       we can improve the error message

##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/MatchRecognizeTest.scala
##########
@@ -70,6 +112,71 @@ class MatchRecognizeTest extends TableTestBase {
     util.verifyRelPlan(sqlQuery)
   }
 
+  def testWindowTVFOnMatchRecognizeOnRowtimeLTZ(): Unit = {

Review comment:
       add  `@Test`

##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/MatchRowTimeFunction.java
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.sql;
+
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlFunction;
+import org.apache.calcite.sql.SqlFunctionCategory;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperandCountRange;
+import org.apache.calcite.sql.SqlOperatorBinding;
+import org.apache.calcite.sql.type.SqlOperandCountRanges;
+
+import java.util.List;
+
+/**
+ * The function used to access a rowtime attribute with TIMESTAMP or TIMESTAMP_LTZ type from
+ * MATCH_RECOGNIZE clause. The function accepts zero or one operand which is a field reference with
+ * rowtime attribute. If there is no operand, the function will return rowtime attribute with
+ * TIMESTAMP type. Otherwise, the return type will be same with the operand type.
+ */
+public class MatchRowTimeFunction extends SqlFunction {
+
+    public MatchRowTimeFunction() {
+        super(
+                "MATCH_ROWTIME",
+                SqlKind.OTHER_FUNCTION,
+                null,
+                null,
+                null,
+                SqlFunctionCategory.MATCH_RECOGNIZE);
+    }
+
+    @Override
+    public String getAllowedSignatures(String opNameToUse) {
+        return "MATCH_ROWTIME([rowtime_field])";
+    }
+
+    @Override
+    public SqlOperandCountRange getOperandCountRange() {
+        return SqlOperandCountRanges.between(0, 1);
+    }
+
+    public String getSignatureTemplate(final int operandsCount) {
+        switch (operandsCount) {
+            case 0:
+                return "{}";
+            case 1:
+                return "{0})";
+            default:
+                throw new AssertionError();
+        }
+    }
+
+    @Override
+    public boolean checkOperandTypes(SqlCallBinding callBinding, boolean throwOnFailure) {
+        List<SqlNode> operands = callBinding.operands();
+        int n = operands.size();
+        assert n == 0 || n == 1;
+        if (n == 0) {
+            return true;
+        } else {
+            SqlNode operand = callBinding.operand(0);
+            if (operand.getKind() != SqlKind.IDENTIFIER) {
+                if (throwOnFailure) {
+                    ValidationException exception =
+                            new ValidationException(
+                                    String.format(
+                                            "The function %s requires a field reference as argument, but actual argument is '%s'.",
+                                            callBinding.getOperator().getName(),
+                                            operand.getKind()));
+                    throw exception;
+                } else {
+                    return false;
+                }
+            }
+            RelDataType operandType = callBinding.getOperandType(0);
+            if (FlinkTypeFactory.isRowtimeIndicatorType(operandType)) {
+                return true;
+            } else {
+                if (throwOnFailure) {
+                    ValidationException exception =

Review comment:
       ditto

##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/MatchRowTimeFunction.java
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.sql;
+
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlFunction;
+import org.apache.calcite.sql.SqlFunctionCategory;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperandCountRange;
+import org.apache.calcite.sql.SqlOperatorBinding;
+import org.apache.calcite.sql.type.SqlOperandCountRanges;
+
+import java.util.List;
+
+/**
+ * The function used to access a rowtime attribute with TIMESTAMP or TIMESTAMP_LTZ type from
+ * MATCH_RECOGNIZE clause. The function accepts zero or one operand which is a field reference with
+ * rowtime attribute. If there is no operand, the function will return rowtime attribute with
+ * TIMESTAMP type. Otherwise, the return type will be same with the operand type.
+ */
+public class MatchRowTimeFunction extends SqlFunction {
+
+    public MatchRowTimeFunction() {
+        super(
+                "MATCH_ROWTIME",
+                SqlKind.OTHER_FUNCTION,
+                null,
+                null,
+                null,
+                SqlFunctionCategory.MATCH_RECOGNIZE);
+    }
+
+    @Override
+    public String getAllowedSignatures(String opNameToUse) {
+        return "MATCH_ROWTIME([rowtime_field])";
+    }
+
+    @Override
+    public SqlOperandCountRange getOperandCountRange() {
+        return SqlOperandCountRanges.between(0, 1);
+    }
+
+    public String getSignatureTemplate(final int operandsCount) {
+        switch (operandsCount) {
+            case 0:
+                return "{}";
+            case 1:
+                return "{0})";
+            default:
+                throw new AssertionError();
+        }
+    }
+
+    @Override
+    public boolean checkOperandTypes(SqlCallBinding callBinding, boolean throwOnFailure) {
+        List<SqlNode> operands = callBinding.operands();
+        int n = operands.size();
+        assert n == 0 || n == 1;
+        if (n == 0) {
+            return true;
+        } else {
+            SqlNode operand = callBinding.operand(0);
+            if (operand.getKind() != SqlKind.IDENTIFIER) {
+                if (throwOnFailure) {
+                    ValidationException exception =

Review comment:
       inline variable

##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -121,18 +107,9 @@ public void lookupOperatorOverloads(
 
     /**
      * Function used to access a event time attribute with TIMESTAMP or TIMESTAMP_LTZ type from

Review comment:
       typo: a -> an




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24181",
       "triggerID" : "c8ea9552f00c97efc8cbb3e19fa23b89b8c69772",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24240",
       "triggerID" : "5e5c83a827211b9a5d8337d58bcf352c7fc37a4f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243",
       "triggerID" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cdf36a2de30c3f50128af2ec881cd65b66b00bfa",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24243",
       "triggerID" : "921637414",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1d732908701d8d51bf7744e4749d34d60ac68c35",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24258",
       "triggerID" : "1d732908701d8d51bf7744e4749d34d60ac68c35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1d732908701d8d51bf7744e4749d34d60ac68c35 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24258) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17205: [FLINK-24168][table-planner] Update MATCH_ROWTIME function which could receive 0 argument or 1 argument

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17205:
URL: https://github.com/apache/flink/pull/17205#issuecomment-915449441


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23799",
       "triggerID" : "911c37bbcc7b9ec9603ae72bede52bc2b464642c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23807",
       "triggerID" : "7e524508a999c88c22e981f9ec8a6fcdc6cb07bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123",
       "triggerID" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "triggerType" : "PUSH"
     }, {
       "hash" : "170096fc6b1f13b86f5ceecfad89f8bf61b16181",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "920515148",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 170096fc6b1f13b86f5ceecfad89f8bf61b16181 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24123) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org