You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/20 22:23:47 UTC
[GitHub] [spark] RussellSpitzer opened a new pull request #34344: SPARK-37061: Fix CustomMetrics when using Inner Classes
RussellSpitzer opened a new pull request #34344:
URL: https://github.com/apache/spark/pull/34344
### What changes were proposed in this pull request?
Previously CustomMetrics use Class.getCanonicalName when attempting to get the
class name of CustomMetric implementations. These names replace special characters
for marking inner classes like ($) with ".". While those names are appropriate for
referring to classes within source files, they will not work during reflection where
the Class.getName output should be used.
### Why are the changes needed?
InnerClasses could never be found in when they are used as Custom Metrics
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Tests modified so they access both an independent metric class as well as an inner class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] RussellSpitzer closed pull request #34344: SPARK-37061: Fix CustomMetrics when using Inner Classes
Posted by GitBox <gi...@apache.org>.
RussellSpitzer closed pull request #34344:
URL: https://github.com/apache/spark/pull/34344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] RussellSpitzer closed pull request #34344: SPARK-37061: Fix CustomMetrics when using Inner Classes
Posted by GitBox <gi...@apache.org>.
RussellSpitzer closed pull request #34344:
URL: https://github.com/apache/spark/pull/34344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34344: SPARK-37061: Fix CustomMetrics when using Inner Classes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34344:
URL: https://github.com/apache/spark/pull/34344#issuecomment-948090753
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org