You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/25 09:03:45 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2920: risc-v/esp32c3: Configure clock and call board initialize at startup.
Ouss4 opened a new pull request #2920:
URL: https://github.com/apache/incubator-nuttx/pull/2920
## Summary
Configure clock and call board initialise at startup.
## Impact
Only ESP32-C3
## Testing
esp32c3-devkit:nsh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #2920: risc-v/esp32c3: Configure clock and call board initialize at startup.
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #2920:
URL: https://github.com/apache/incubator-nuttx/pull/2920#discussion_r582681012
##########
File path: arch/risc-v/src/esp32c3/esp32c3_start.c
##########
@@ -83,7 +84,15 @@ void __esp32c3_start(void)
showprogress('B');
- /* Call nx_start() */
+ /* Set CPU frequency */
+
+ esp32c3_clockconfig();
Review comment:
Shouldn't the clock configuration be performed before the call to `esp32c3_lowsetup()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2920: risc-v/esp32c3: Configure clock and call board initialize at startup.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2920:
URL: https://github.com/apache/incubator-nuttx/pull/2920
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org