[GitHub] [spark] Ngone51 commented on a change in pull request #29789: [SPARK-32898][CORE] Fix wrong executorRunTime when task killed before real start

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #29789:
URL: https://github.com/apache/spark/pull/29789#discussion_r490682482



##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -400,7 +400,10 @@ private[spark] class Executor(
       // Report executor runtime and JVM gc time
       Option(task).foreach(t => {
         t.metrics.setExecutorRunTime(TimeUnit.NANOSECONDS.toMillis(
-          System.nanoTime() - taskStartTimeNs))
+          // SPARK-32898: it's possible that a task be killed before it reaches
+          // "taskStartTimeNs = System.nanoTime()". In this case, the executorRunTime

Review comment:
       Thanks, addressed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org