[GitHub] [superset] kgabryje commented on pull request #18009: feat: log scale and step size control for range filters [WIP]

[GitBox <gi...@apache.org>]

kgabryje commented on pull request #18009:
URL: https://github.com/apache/superset/pull/18009#issuecomment-1084323798


   Thanks for the improvement @stevetracvc!
   1 issue that I spotted while testing - if the upper range value is smaller then `current value + step`, then we can't select it. For example, in the video my range is about [0, 41]. When I select step 25, then I can only select values 0 and 25. I think 41 should also be selectable, even if that would mean making smaller step. WDYT?
   
   https://user-images.githubusercontent.com/15073128/161023937-9bfd852a-5ffd-4b0c-8c66-dd30da52d725.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org