[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19858: [fix] [cli] Release the orphan producers after the primary consumer is closed

["mattisonchao (via GitHub)" <gi...@apache.org>]

mattisonchao commented on code in PR #19858:
URL: https://github.com/apache/pulsar/pull/19858#discussion_r1143424835


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -1050,7 +1050,19 @@ public CompletableFuture<Void> closeAsync() {
             });
         }
 
-        return closeFuture;
+        return closeFuture.thenCompose(ignore -> {
+            if (retryLetterProducer != null){
+                return retryLetterProducer.closeAsync();

Review Comment:
   Should we close them parallel? should we do some special exception handling here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org