[jira] [Commented] (SPARK-14386) spark.ml DecisionTreeModel abstraction should not be exposed

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-14386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225196#comment-15225196 ] 

Apache Spark commented on SPARK-14386:
--------------------------------------

User 'jkbradley' has created a pull request for this issue:
https://github.com/apache/spark/pull/12158

> spark.ml DecisionTreeModel abstraction should not be exposed
> ------------------------------------------------------------
>
>                 Key: SPARK-14386
>                 URL: https://issues.apache.org/jira/browse/SPARK-14386
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>            Reporter: Joseph K. Bradley
>            Assignee: Joseph K. Bradley
>
> In spark.ml, GBT and RandomForest expose the trait DecisionTreeModel in the {{trees}} method, but they should not since it is a private trait (and not ready to be made public).  It will also be more useful to users if we return the concrete types.
> Proposal: return concrete types
> * The MIMA checks appear to be OK with this change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org