[GitHub] [incubator-superset] ktmud commented on pull request #11407: fix: added meaningful exception for loading births error

[GitBox <gi...@apache.org>]

ktmud commented on pull request #11407:
URL: https://github.com/apache/incubator-superset/pull/11407#issuecomment-715617115


   I think raising an Exception is good. Thanks for catching and fixing this error!
   
   Maybe we can change the default "admin" user to the first user in db, too? In case users used `superset fab create-admin` to add the first user but didn't set `admin` as the user name.
   
   ```python
   admin = (
       db.session.query(security_manager.user_model)
       .order_by(security_manager.user_model.id)
       .first()
   )
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org