You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/26 08:58:19 UTC

[GitHub] [shardingsphere] Swastyy opened a new pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Swastyy opened a new pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741


   Fixes #12563 
   
   Changes proposed in this pull request:
   -
   -
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-929888995






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang edited a comment on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
RaigorJiang edited a comment on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-931443009


   I am so sorry. @Swastyy 
   It is a pity that the adjustment of a shadow example was merged before this, which brought us trouble again.
   Sorry, can you consider starting from the master branch again?
   Refer to #https://github.com/apache/shardingsphere/pull/12866.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-931443009


   I am so sorry. @Swastyy 
   It is a pity that the adjustment of a shadow example was merged before this, which brought us trouble again.
   Sorry, can you consider starting from the master branch again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-927305850


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12741?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#12741](https://codecov.io/gh/apache/shardingsphere/pull/12741?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60720e9) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0a2a4b9b63518357eb2caf036581b5e1e547533f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a2a4b9) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/12741/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/12741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #12741      +/-   ##
   ============================================
   - Coverage     63.26%   63.25%   -0.02%     
   - Complexity     1347     1349       +2     
   ============================================
     Files          2475     2479       +4     
     Lines         37356    37369      +13     
     Branches       6433     6434       +1     
   ============================================
   + Hits          23634    23638       +4     
   - Misses        11807    11816       +9     
     Partials       1915     1915              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/12741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/12741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
   | [...ized/asserts/statement/dal/DALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGFsL0RBTFN0YXRlbWVudEFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...tement/dal/ShowCreateTriggerStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/12741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc3RhdGVtZW50L2RhbC9TaG93Q3JlYXRlVHJpZ2dlclN0YXRlbWVudFRlc3RDYXNlLmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...s/domain/segment/impl/trigger/ExpectedTrigger.java](https://codecov.io/gh/apache/shardingsphere/pull/12741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc2VnbWVudC9pbXBsL3RyaWdnZXIvRXhwZWN0ZWRUcmlnZ2VyLmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...ent/mysql/dal/MySQLShowCreateTriggerStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/12741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvbXlzcWwvZGFsL015U1FMU2hvd0NyZWF0ZVRyaWdnZXJTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ent/dal/impl/ShowCreateTriggerStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGFsL2ltcGwvU2hvd0NyZWF0ZVRyaWdnZXJTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...eterized/jaxb/cases/domain/SQLParserTestCases.java](https://codecov.io/gh/apache/shardingsphere/pull/12741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vU1FMUGFyc2VyVGVzdENhc2VzLmphdmE=) | `99.64% <0.00%> (+<0.01%)` | :arrow_up: |
   | [...or/statement/impl/MySQLDALStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/12741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMREFMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `43.02% <0.00%> (+1.01%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12741?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12741?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0a2a4b9...60720e9](https://codecov.io/gh/apache/shardingsphere/pull/12741?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-931455181


   > I am so sorry. @Swastyy It is a pity that the adjustment of a shadow example was merged before this, which brought us trouble again. Sorry, can you consider starting from the master branch again? Refer to ##12866.
   
   Ah, okk I will close this PR and create a new PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-930942347


   Also @RaigorJiang I am not able to resolve conflicts directly, it maybe because of the files have been moved to another location(which are moved in this PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-931477469


   Thanks a lot!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-929888995


   @Swastyy 
   Thank you for the great work, I only found some minor problems:
   After the module adjustment, the parent of the following modules should be changed to `single-feature-example`:
   - cluster-mode-example
   - encrypt-example
   - extension-example
   - future-shadow-example
   - shadow-example
   - sharding-example
   - transaction-example


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-928765297


   There are a lot of files affected by this PR, and I have started to review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-929890321


   Due to the merger of #12796, there is a little conflict here. Please resolve.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy closed pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
Swastyy closed pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-931109273


   Hi @Swastyy 
   Don't worry, to resolve this conflict, you need to:
   1. Checkout to your `local master branch`(any branch name) and synchronize from the `apache master`;
   2. Checkout back to `Swastyy:12563`, and merge local master branch into current branch;
   3. Resolve the conflict and modify it to the desired state;
   4. Commit and push;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-930933845


   > Due to the merger of #12796, there is a little conflict here. Please resolve.
   
   @RaigorJiang I am not sure if the file I have imported (in the newest commit) is from the correct location. Please let me know if there is something wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #12741: Creating `single-feature-example` for `shardingsphere-jdbc-example`.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #12741:
URL: https://github.com/apache/shardingsphere/pull/12741#issuecomment-928765297


   There are a lot of files affected by this PR, and I have started to review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org