You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Rancho-7 (via GitHub)" <gi...@apache.org> on 2024/11/22 12:07:45 UTC
[PR] Minor: add a note to the upgrade notes [kafka]
Rancho-7 opened a new pull request, #17910:
URL: https://github.com/apache/kafka/pull/17910
add a note to the upgrade notes
JIRA:[issues.apache.org/jira/browse/KAFKA-12690](https://issues.apache.org/jira/browse/KAFKA-12690)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [x] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: add a note to the upgrade notes [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17910:
URL: https://github.com/apache/kafka/pull/17910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: add a note to the upgrade notes [kafka]
Posted by "Rancho-7 (via GitHub)" <gi...@apache.org>.
Rancho-7 commented on code in PR #17910:
URL: https://github.com/apache/kafka/pull/17910#discussion_r1854973763
##########
docs/upgrade.html:
##########
@@ -137,6 +137,8 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
<ul>
<li>The <code>enable.idempotence</code> configuration will no longer automatically fall back when the <code>max.in.flight.requests.per.connection</code> value exceeds 5.
</li>
+ <li>The deprecated <code>sendOffsetsToTransaction</code> method has been removed from the Producer API.
Review Comment:
> Could you please use `sendOffsetsToTransaction(Map<TopicPartition, OffsetAndMetadata>, String)` instead?
Sure.
<img width="685" alt="Snipaste_2024-11-23_17-43-14" src="https://github.com/user-attachments/assets/1b6a4160-e663-4469-9a16-465096e44e78">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: add a note to the upgrade notes [kafka]
Posted by "Rancho-7 (via GitHub)" <gi...@apache.org>.
Rancho-7 commented on code in PR #17910:
URL: https://github.com/apache/kafka/pull/17910#discussion_r1854973763
##########
docs/upgrade.html:
##########
@@ -137,6 +137,8 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
<ul>
<li>The <code>enable.idempotence</code> configuration will no longer automatically fall back when the <code>max.in.flight.requests.per.connection</code> value exceeds 5.
</li>
+ <li>The deprecated <code>sendOffsetsToTransaction</code> method has been removed from the Producer API.
Review Comment:
> Could you please use `sendOffsetsToTransaction(Map<TopicPartition, OffsetAndMetadata>, String)` instead?
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: add a note to the upgrade notes [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17910:
URL: https://github.com/apache/kafka/pull/17910#discussion_r1854096964
##########
docs/upgrade.html:
##########
@@ -137,6 +137,8 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
<ul>
<li>The <code>enable.idempotence</code> configuration will no longer automatically fall back when the <code>max.in.flight.requests.per.connection</code> value exceeds 5.
</li>
+ <li>The deprecated <code>sendOffsetsToTransaction</code> method has been removed from the Producer API.
Review Comment:
Could you please use `sendOffsetsToTransaction(Map<TopicPartition, OffsetAndMetadata>, String)` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org