You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/08/28 22:47:16 UTC
[GitHub] couchdb-fauxton pull request: Updating Fauxton layout to use flexb...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/507
Updating Fauxton layout to use flexbox - #1
This is a first salvo for cleaning up the layout CSS for Fauxton.
Right now it’s kind of a mess: lots of floats, position
absolutes/fixed’s and more. This PR focuses on updating the
with_tabs_sidebar.html template so the main panel uses flexbox:
meaning the optional tab row, body content and optional footer.
All Fauxton pages should look identical to before, except it
fixes a small issue where the scrollbar for the main panel
on the Changes page (and other pages) kind of scrolls off the
top.
Benefits to using flexbox are:
- we can drop a LOT of complicated CSS once it’s all ported over
- flexbox is much easier to understand than older methods
- we can drop the position:fixed + z-indexes that cause issues
with embedding modals anywhere in the DOM (and have the
backdrop appear properly).
Affected pages:
- all pages in the Databases section
- Config page (single node)
Tested on Chrome 44, FF 40, Safari 7.05, IE 10
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton layout-updates
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/507.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #507
----
commit 8ecd2b0fff5e3965a76076909c25e90138ba30db
Author: Ben Keen <be...@gmail.com>
Date: 2015-08-28T18:29:24Z
Updating Fauxton layout to use flexbox - #1
This is a first salvo for cleaning up the layout CSS for Fauxton.
Right now it’s kind of a mess: lots of floats, position
absolutes/fixed’s and more. This PR focuses on updating the
with_tabs_sidebar.html template so the main panel uses flexbox:
meaning the optional tab row, body content and optional footer.
All Fauxton pages should look identical to before, except it
fixes a small issue where the scrollbar for the main panel
on the Changes page (and other pages) kind of scrolls off the
top.
Benefits to using flexbox are:
- we can drop a LOT of complicated CSS once it’s all ported over
- flexbox is much easier to understand than older methods
- we can drop the position:fixed + z-indexes that cause issues
with embedding modals anywhere in the DOM (and have the
backdrop appear properly).
Affected pages:
- all pages in the Databases section
- Config page (single node)
Tested on Chrome 44, FF 40, Safari 7.05, IE 10
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Updating Fauxton layout to use flexb...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Updating Fauxton layout to use flexb...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/507#issuecomment-136418785
Thanks, Robert! Nice to get this one in. Merged as 5f52818
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Updating Fauxton layout to use flexb...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/507#issuecomment-136379160
neat!
also great docs in form of the commit message!
big +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---