You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/07 22:14:41 UTC

[GitHub] [tvm] mbs-octoml opened a new pull request, #11616: [Relay] Restore dominator check

mbs-octoml opened a new pull request, #11616:
URL: https://github.com/apache/tvm/pull/11616

   I goofed in #11481 in moving a dominates check to
   an ICHECK (and I'm confused how it got through ci?).
   
   It is ok to match a sub-graph which has dataflow
   outside of the sub-graph, provided all such flows
   eventually come into the sub-graph.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Mousius commented on pull request #11616: [Relay] Restore dominator check

Posted by GitBox <gi...@apache.org>.
Mousius commented on PR #11616:
URL: https://github.com/apache/tvm/pull/11616#issuecomment-1149715526

   LGTM @mbs-octoml 😸 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Mousius merged pull request #11616: [Relay] Restore dominator check

Posted by GitBox <gi...@apache.org>.
Mousius merged PR #11616:
URL: https://github.com/apache/tvm/pull/11616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] mbs-octoml commented on pull request #11616: [Relay] Restore dominator check

Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on PR #11616:
URL: https://github.com/apache/tvm/pull/11616#issuecomment-1149253769

   Now with unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] mbs-octoml commented on pull request #11616: [Relay] Restore dominator check

Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on PR #11616:
URL: https://github.com/apache/tvm/pull/11616#issuecomment-1149226545

   Trying to come up with a unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org