You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/02/27 19:28:34 UTC
[Impala-ASF-CR] IMPALA-11952 (part 4): Fix odds and ends: Octals, long, lambda, etc.
Joe McDonnell has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19554 )
Change subject: IMPALA-11952 (part 4): Fix odds and ends: Octals, long, lambda, etc.
......................................................................
IMPALA-11952 (part 4): Fix odds and ends: Octals, long, lambda, etc.
There are a variety of small python 3 syntax differences:
- Octals constants need to start with 0o rather than just 0
- Long constants are not supports (i.e. numbers ending with L)
- Lambda syntax is slightly different
- The 'ur' string mode is no longer supported
Testing:
- check-python-syntax.sh now passes
Change-Id: Ie027a50ddf6a2a0db4b34ec9b49484ce86947f20
---
M bin/check-rat-report.py
M docker/test-with-docker.py
M tests/comparison/data_generator_mapred_common.py
M tests/comparison/leopard/front_end.py
M tests/comparison/leopard/impala_docker_env.py
M tests/comparison/leopard/report.py
M tests/custom_cluster/test_breakpad.py
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_thrift_socket.py
M tests/util/get_parquet_metadata.py
10 files changed, 29 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/19554/2
--
To view, visit http://gerrit.cloudera.org:8080/19554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie027a50ddf6a2a0db4b34ec9b49484ce86947f20
Gerrit-Change-Number: 19554
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>