You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by siyuanh <gi...@git.apache.org> on 2015/12/07 07:07:31 UTC
[GitHub] incubator-apex-malhar pull request: Safe offset update and report
GitHub user siyuanh opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/120
Safe offset update and report
@tushargosavi @chaithu14 please review this change
@PramodSSImmaneni This is the offset fix for your request
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/siyuanh/incubator-apex-malhar MHLR-19251928
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit d719429c486f685aa6f8964de89b9fe4fd0ab379
Author: Siyuan Hua <hs...@apache.org>
Date: 2015-12-07T05:55:38Z
MLHR-1925 #resolve #comment report stats of offsets in committed window only
MLHR-1928 #resolve #comment update offsets after emit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: Safe offset update and report
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/120#discussion_r47136110
--- Diff: contrib/src/main/java/com/datatorrent/contrib/kafka/AbstractKafkaInputOperator.java ---
@@ -301,12 +312,10 @@ protected void replay(long windowId)
@Override
public void endWindow()
{
+ Map<KafkaPartition, Long> carryOn = new HashMap<>(offsetStats);
+ offsetTrackHistory.add(Pair.of(currentWindowId, carryOn));
--- End diff --
This should only be done for the simple consumer as that's the condition to clear the state in committed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: Safe offset update and report
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---