[GitHub] [pinot] KKcorps opened a new pull request, #9410: Bug fix: failure status in ingestion jobs doesn't reflect in exit code

[GitBox <gi...@apache.org>]

KKcorps opened a new pull request, #9410:
URL: https://github.com/apache/pinot/pull/9410

   The CommandLine.execute method by default absorbs all the exceptions according to the documentation and only provides a proper exit code. In our ingestion job commands, we ignore this exitCode thus marking our jobs as success even in the case of failures. 
   
   This is inline with the practice mentioned in picocli javadocs - https://picocli.info/apidocs/picocli/CommandLine.html#execute-java.lang.String...- 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] Jackie-Jiang merged pull request #9410: Bug fix: failure status in ingestion jobs doesn't reflect in exit code

[GitBox <gi...@apache.org>]

Jackie-Jiang merged PR #9410:
URL: https://github.com/apache/pinot/pull/9410


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org