You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/23 06:26:55 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request, #17230: [improve][admin] Make deleteNamesapce api async
gaozhangmin opened a new pull request, #17230:
URL: https://github.com/apache/pulsar/pull/17230
### Motivation
See PIP #14365 and change tracker #15043.
Make deleteNemspace admin api async
### Modifications
Make deleteNemspace admin api async
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #17230: [improve][admin] Make deleteNamesapce api async
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #17230:
URL: https://github.com/apache/pulsar/pull/17230#issuecomment-1229905963
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin merged pull request #17230: [improve][admin] Make deleteNamesapce api async
Posted by GitBox <gi...@apache.org>.
gaozhangmin merged PR #17230:
URL: https://github.com/apache/pulsar/pull/17230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #17230: [improve][admin] Make deleteNamesapce api async
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on code in PR #17230:
URL: https://github.com/apache/pulsar/pull/17230#discussion_r959776364
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespacesTest.java:
##########
@@ -756,7 +756,7 @@ public void testDeleteNamespaces() throws Exception {
mockZooKeeperGlobal.delete("/admin/partitioned-topics/" + topicName.getPersistenceNamingEncoding(), -1);
- testNs = this.testGlobalNamespaces.get(0);
+ testNs = this.testLocalNamespaces.get(2);
Review Comment:
I change here, because we tried to delete non-persistent topics which previous don't.
When we get full of non-persistent, we should try to get from non-global namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org