[jira] [Commented] (OAK-3449) DocumentNodeStore support for predefined clusterIds should use ClusterNodeInfos

["Julian Reschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907992#comment-14907992 ] 

Julian Reschke commented on OAK-3449:
-------------------------------------

Currently there is some code that assumes that the given cluster id will become the real cluster id. It would be tricky to keep this behavior, because the selected id might be in conflict with currently persisted cluster node infos. Thus it would be best to first remove that assumption from the code base, and to document that the cluster id will only be used to disambiguate NodeStore instances, and to get the final ID, the caller will need to fetch it from the instantiated DocumentNodeStore. 

> DocumentNodeStore support for predefined clusterIds should use ClusterNodeInfos
> -------------------------------------------------------------------------------
>
>                 Key: OAK-3449
>                 URL: https://issues.apache.org/jira/browse/OAK-3449
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, mongomk, rdbmk
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>              Labels: test
>
> We currently support explicit assignment of clusterId (builder.setClusterId()). In this case, DocumentNodeStore uses the specified cluster id and skips all code related to creating/maintaining ClusterNodeInfos.
> This feature is mainly (only?) used for testing (mainly allowing multiple instances to run from the same machine/instance combination). This works, but causes the logic related to ClusterNodeInfo not to be used at all (for instance, LastRevRecovery).
> So we ought to change this config option to use ClusterNodeInfo in a way that is at least similar to real-world use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)