You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "dubbo-go-bot (via GitHub)" <gi...@apache.org> on 2025/11/07 05:55:35 UTC
[PR] Unified metric reporter otel [dubbo-go-pixiu]
dubbo-go-bot opened a new pull request, #799:
URL: https://github.com/apache/dubbo-go-pixiu/pull/799
## 🔄 Upstream Sync from Community Fork
This PR automatically syncs changes from the community fork to the upstream repository.
### Original Contribution
- **Author**: @nanjiek
- **Original PR**: https://github.com/dubbo-go-pixiu/dubbo-go-pixiu/pull/27
- **Merged at**: 2025-11-07 05:55:31 UTC
### Original PR Description
---
update the old DefaultName
## Summary by Sourcery
Unify default metric reporter constants and update config validation to use the new DefaultMetric* constants.
Enhancements:
- Rename and reformat default metric constants in filter.go to use consistent DefaultMetric* naming
- Update Config.Validate methods to apply the new DefaultMetric* constants for mode, gateway URL, job name, interval, and path defaults
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Refactor**
* Standardized internal metric configuration defaults for consistency.
* Improved code formatting and alignment for better maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
All commits preserve original authorship.
**Note**: Auto-created when PR #27 was merged into `dubbo-go-pixiu/dubbo-go-pixiu:develop`.
cc @nanjiek
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: replace the metric filter by a unified metric filter [dubbo-go-pixiu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #799:
URL: https://github.com/apache/dubbo-go-pixiu/pull/799#issuecomment-3500893542
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/799?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `48.08917%` with `163 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 20.97%. Comparing base ([`26606a8`](https://app.codecov.io/gh/apache/dubbo-go-pixiu/commit/26606a8317ac79fb8ce826138a34908b62beae1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f66b1b4`](https://app.codecov.io/gh/apache/dubbo-go-pixiu/commit/f66b1b43f43dd1a4e3380a935d258fec07d8c288?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 83 commits behind head on develop.
| [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/799?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [pkg/prometheus/prometheus.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/799?src=pr&el=tree&filepath=pkg%2Fprometheus%2Fprometheus.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3Byb21ldGhldXMvcHJvbWV0aGV1cy5nbw==) | 0.00% | [108 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/filter/metric/metric.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/799?src=pr&el=tree&filepath=pkg%2Ffilter%2Fmetric%2Fmetric.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | 72.54% | [29 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/filter/llm/proxy/filter.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/799?src=pr&el=tree&filepath=pkg%2Ffilter%2Fllm%2Fproxy%2Ffilter.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2ZpbHRlci9sbG0vcHJveHkvZmlsdGVyLmdv) | 0.00% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/799?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (26606a8) and HEAD (f66b1b4). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (26606a8) | HEAD (f66b1b4) |
>|------|------|------|
>||1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #799 +/- ##
============================================
- Coverage 54.67% 20.97% -33.70%
============================================
Files 671 238 -433
Lines 78658 15418 -63240
============================================
- Hits 43006 3234 -39772
+ Misses 31981 11847 -20134
+ Partials 3671 337 -3334
```
| [Flag](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/799/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [unittests](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/799/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `20.97% <48.08%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/799?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: replace the metric filter by a unified metric filter [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #799:
URL: https://github.com/apache/dubbo-go-pixiu/pull/799#issuecomment-3500879026
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=799) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=799&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=799&metric=new_coverage&view=list)
 [0.4% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=799&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=799)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: replace the metric filter by a unified metric filter [dubbo-go-pixiu]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl merged PR #799:
URL: https://github.com/apache/dubbo-go-pixiu/pull/799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org