You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dajac (via GitHub)" <gi...@apache.org> on 2026/05/12 17:06:59 UTC
[PR] KAFKA-20444: [9/N] Preserve topic-level structure in TxnOffsetCommit response handling (KIP-1319) [kafka]
dajac opened a new pull request, #22265:
URL: https://github.com/apache/kafka/pull/22265
`TxnOffsetCommitHandler.handleResponse` in `TransactionManager`
folded the response into a `Map<TopicPartition, Errors>` via
`TxnOffsetCommitResponse.errors()` before processing it. This loses
the response's topic-level structure, which v6+ (KIP-1319) needs in
order to resolve topic IDs back to names.
This patch switches the handler to iterate directly over
`response.data().topics()` and `responseTopic.partitions()`, so the
per-topic structure is preserved. The error-handling switch ladder is
unchanged; only the iteration shape is different. The now-unused
`TxnOffsetCommitResponse.errors()` accessor is removed along with its
two test usages.
This is a pure refactor: at v0-5, the response topic always carries
the topic name, so `new TopicPartition(responseTopic.name(),
responsePartition.partitionIndex())` reproduces what `errors()` would
have returned. The v6+ wiring that resolves topic IDs back to names
will be added in a follow-up patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20444: [9/N] Preserve topic-level structure in TxnOffsetCommit response handling (KIP-1319) [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #22265:
URL: https://github.com/apache/kafka/pull/22265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org