You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ke...@apache.org on 2005/09/16 02:38:05 UTC

svn commit: r289353 - in /maven/components/trunk/maven-plugins: maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/ maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ maven-war-plugin/src/main/java/org/...

Author: kenney
Date: Thu Sep 15 17:37:58 2005
New Revision: 289353

URL: http://svn.apache.org/viewcvs?rev=289353&view=rev
Log:
o EclipsePlugin now does NOT download sources by default.
  Specify -Declipse.downloadSources=true to do so.

o WarMojo produces an artifact, even if exploded is specified. This makes sure
  that the install phase doesn't fail because there's no artifact.

o DependenciesReport: add caught exception to the new thrown exception
  for better messages.

Modified:
    maven/components/trunk/maven-plugins/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
    maven/components/trunk/maven-plugins/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/DependenciesReport.java
    maven/components/trunk/maven-plugins/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/WarMojo.java

Modified: maven/components/trunk/maven-plugins/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-plugins/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java?rev=289353&r1=289352&r2=289353&view=diff
==============================================================================
--- maven/components/trunk/maven-plugins/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java (original)
+++ maven/components/trunk/maven-plugins/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java Thu Sep 15 17:37:58 2005
@@ -143,7 +143,7 @@
      * 
      * @parameter expression="${eclipse.downloadSources}"
      */
-    private boolean downloadSources = true;
+    private boolean downloadSources = false;
 
     /**
      * Eclipse workspace directory.

Modified: maven/components/trunk/maven-plugins/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/DependenciesReport.java
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-plugins/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/DependenciesReport.java?rev=289353&r1=289352&r2=289353&view=diff
==============================================================================
--- maven/components/trunk/maven-plugins/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/DependenciesReport.java (original)
+++ maven/components/trunk/maven-plugins/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/DependenciesReport.java Thu Sep 15 17:37:58 2005
@@ -279,7 +279,7 @@
                         throw new IllegalArgumentException( "Can't find a valid Maven project in the repository for the artifact ["
                                                                 + artifact.getGroupId() + ":"
                                                                 + artifact.getArtifactId() + ":"
-                                                                + artifact.getVersion() + "]." );
+                                                                + artifact.getVersion() + "].", e );
                     }
                     tableRow( new String[]{artifact.getGroupId(), artifact.getArtifactId(), artifact.getVersion(),
                         artifactProject.getDescription(),

Modified: maven/components/trunk/maven-plugins/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/WarMojo.java
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-plugins/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/WarMojo.java?rev=289353&r1=289352&r2=289353&view=diff
==============================================================================
--- maven/components/trunk/maven-plugins/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/WarMojo.java (original)
+++ maven/components/trunk/maven-plugins/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/WarMojo.java Thu Sep 15 17:37:58 2005
@@ -314,7 +314,10 @@
         {
             generateExplodedWebapp();
 
-            if ( !"exploded".equals( mode ) )
+            // TODO: make a separate 'exploded' Mojo. For now,
+            // disable not making an artifact so the install phase
+            // doesn't fail.
+            // if ( !"exploded".equals( mode ) )
             {
                 //generate war file
                 getLog().info( "Generating war " + warFile.getAbsolutePath() );



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r289353 - in /maven/components/trunk/maven-plugins: maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/ maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ maven-war-plugin/src/main/jav

Posted by Mark Hobson <ma...@gmail.com>.
On 16/09/05, Brett Porter <br...@apache.org> wrote:
> Yes, just discussed with Kenney - will rollback this change for this
> release. Expecting an additional release next week.

Great, thanks guys.  I'll try to leave you alone now ;)

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r289353 - in /maven/components/trunk/maven-plugins: maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/ maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ maven-war-plugin/src/main/jav

Posted by Brett Porter <br...@apache.org>.
Yes, just discussed with Kenney - will rollback this change for this
release. Expecting an additional release next week.

- Brett

Mark Hobson wrote:

>Brett, I know you're busy releasing everything at the mo, but do you
>think this'll be fixed for the release?
>
>Mark
>
>On 16/09/05, Mark Hobson <ma...@gmail.com> wrote:
>  
>
>>On 16/09/05, Brett Porter <br...@apache.org> wrote:
>>    
>>
>>>The WAR plugin isn't released yet, so we may still get a chance to allow
>>>it to do both (ie, exploded also wars it up). Is that useful?
>>>      
>>>
>>Phew, that was a close one ;)  I basically need the functionality from
>>before Kenney's commit, i.e.
>>
>>-            // if ( !"exploded".equals( mode ) )
>>+            if ( !"exploded".equals( mode ) )
>>
>>So both mode="war" and mode="exploded" arrange the exploded war in
>>target/finalName, but *only* mode="war" will war up the files into
>>target/finalName.war.
>>
>>I understand what Kenney wanted to fix (missing war on m2 install with
>>mode != "war"), but I feel that error message is better than losing
>>this functionality.
>>
>>    
>>
>>>Regardless, a new release can be made at any time - no more tying
>>>plugins to m2 releases.
>>>      
>>>
>>Great, that's good news.
>>
>>Cheers,
>>
>>Mark
>>
>>    
>>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>For additional commands, e-mail: dev-help@maven.apache.org
>
>  
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r289353 - in /maven/components/trunk/maven-plugins: maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/ maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ maven-war-plugin/src/main/jav

Posted by Mark Hobson <ma...@gmail.com>.
Brett, I know you're busy releasing everything at the mo, but do you
think this'll be fixed for the release?

Mark

On 16/09/05, Mark Hobson <ma...@gmail.com> wrote:
> On 16/09/05, Brett Porter <br...@apache.org> wrote:
> > The WAR plugin isn't released yet, so we may still get a chance to allow
> > it to do both (ie, exploded also wars it up). Is that useful?
> 
> Phew, that was a close one ;)  I basically need the functionality from
> before Kenney's commit, i.e.
> 
> -            // if ( !"exploded".equals( mode ) )
> +            if ( !"exploded".equals( mode ) )
> 
> So both mode="war" and mode="exploded" arrange the exploded war in
> target/finalName, but *only* mode="war" will war up the files into
> target/finalName.war.
> 
> I understand what Kenney wanted to fix (missing war on m2 install with
> mode != "war"), but I feel that error message is better than losing
> this functionality.
> 
> > Regardless, a new release can be made at any time - no more tying
> > plugins to m2 releases.
> 
> Great, that's good news.
> 
> Cheers,
> 
> Mark
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r289353 - in /maven/components/trunk/maven-plugins: maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/ maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ maven-war-plugin/src/main/jav

Posted by Mark Hobson <ma...@gmail.com>.
On 16/09/05, Brett Porter <br...@apache.org> wrote:
> The WAR plugin isn't released yet, so we may still get a chance to allow
> it to do both (ie, exploded also wars it up). Is that useful?

Phew, that was a close one ;)  I basically need the functionality from
before Kenney's commit, i.e.

-            // if ( !"exploded".equals( mode ) )
+            if ( !"exploded".equals( mode ) )

So both mode="war" and mode="exploded" arrange the exploded war in
target/finalName, but *only* mode="war" will war up the files into
target/finalName.war.

I understand what Kenney wanted to fix (missing war on m2 install with
mode != "war"), but I feel that error message is better than losing
this functionality.

> Regardless, a new release can be made at any time - no more tying
> plugins to m2 releases.

Great, that's good news.

Cheers,

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r289353 - in /maven/components/trunk/maven-plugins: maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/ maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ maven-war-plugin/src/main/jav

Posted by Brett Porter <br...@apache.org>.
The WAR plugin isn't released yet, so we may still get a chance to allow
it to do both (ie, exploded also wars it up). Is that useful?

Regardless, a new release can be made at any time - no more tying
plugins to m2 releases.

- Brett

Mark Hobson wrote:

>On 16/09/05, kenney@apache.org <ke...@apache.org> wrote:
>  
>
>>+++ maven/components/trunk/maven-plugins/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/WarMojo.java Thu Sep 15 17:37:58 2005
>>@@ -314,7 +314,10 @@
>>         {
>>             generateExplodedWebapp();
>>
>>-            if ( !"exploded".equals( mode ) )
>>+            // TODO: make a separate 'exploded' Mojo. For now,
>>+            // disable not making an artifact so the install phase
>>+            // doesn't fail.
>>+            // if ( !"exploded".equals( mode ) )
>>             {
>>                 //generate war file
>>                 getLog().info( "Generating war " + warFile.getAbsolutePath() );
>>    
>>
>
>This obviously stops mode="exploded" from doing anything useful now :(
> I use this loads to save warring-up my 15mb webapp when deploying
>inplace to tomcat, since the zipping process is quite slow when in
>development.
>
>Looks like any fix missed the beta1 boat whilst I was asleep..  would
>I have to wait until beta2 for this or could an updated war plugin be
>released in the meantime?
>
>Cheers,
>
>Mark
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>For additional commands, e-mail: dev-help@maven.apache.org
>
>  
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r289353 - in /maven/components/trunk/maven-plugins: maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/ maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ maven-war-plugin/src/main/jav

Posted by Mark Hobson <ma...@gmail.com>.
On 16/09/05, kenney@apache.org <ke...@apache.org> wrote:
> +++ maven/components/trunk/maven-plugins/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/WarMojo.java Thu Sep 15 17:37:58 2005
> @@ -314,7 +314,10 @@
>          {
>              generateExplodedWebapp();
> 
> -            if ( !"exploded".equals( mode ) )
> +            // TODO: make a separate 'exploded' Mojo. For now,
> +            // disable not making an artifact so the install phase
> +            // doesn't fail.
> +            // if ( !"exploded".equals( mode ) )
>              {
>                  //generate war file
>                  getLog().info( "Generating war " + warFile.getAbsolutePath() );

This obviously stops mode="exploded" from doing anything useful now :(
 I use this loads to save warring-up my 15mb webapp when deploying
inplace to tomcat, since the zipping process is quite slow when in
development.

Looks like any fix missed the beta1 boat whilst I was asleep..  would
I have to wait until beta2 for this or could an updated war plugin be
released in the meantime?

Cheers,

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r289353 - in /maven/components/trunk/maven-plugins: maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/ maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ maven-war-plugin/src/main/jav

Posted by Brett Porter <br...@apache.org>.
Fabrizio Giustina wrote:

>Did anybody discuss about the distribution of source archives in the
>m2 ibiblio repo? What about star trying that for a few projects now?
>  
>
We're doing this by default, though a glitch in the release plugin means
only some of the recent releases had source archives. Will get it
resolved by m2 final.

Examples:
http://www.ibiblio.org/maven2/org/apache/maven/plugins/maven-idea-plugin/2.0-beta-1/maven-idea-plugin-2.0-beta-1-sources.jar

Cheers,
Brett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r289353 - in /maven/components/trunk/maven-plugins: maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/ maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/ maven-war-plugin/src/main/jav

Posted by Fabrizio Giustina <fg...@gmail.com>.
On 9/16/05, kenney@apache.org <ke...@apache.org> wrote:
> Author: kenney
> o EclipsePlugin now does NOT download sources by default.
>   Specify -Declipse.downloadSources=true to do so.

kenney, do you really think that we need to turn this off by default?
I think this is a feature that most m2/eclipse users would like to use
and I would like to have enabled by default, without forcing users to
look at the documentation to understand that this have been finally
implemented in m2 and that they need to configure the
"eclipse.downloadSources" property if they want to use it.

Downloading of source archives is a thing I always missed in m1: just
now it probably seems a little useless, unless you have a private
repository where you manually added source jars for the dependencies
you are using (like I did), but I hope that we could start uploading
sources to public repositories too, now that maven handles that (the
source plugin can generate such artifacts and the deploy plugin
handles them).

For example, I would like to see sources for plexus, doxia, and maven
related libs available in the central repo, so that javadocs and debug
support are available in eclipse without having to checkout the
project from cvs and manually changing the eclipse mapping (or
deploying the source archive to my local repo).

What about leaving the "eclipse.downloadSources" property but with a
default to ON? If users know that sources are not available they can
set it to off or they can simply run maven -o if they want to
configure a project that have been already built using maven and for
which  all the dependencies are available in in the local maven repo.

Did anybody discuss about the distribution of source archives in the
m2 ibiblio repo? What about star trying that for a few projects now?

fabrizio

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org