[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #301: Avoid write failures if metrics mode is invalid

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #301: Avoid write failures if metrics mode is invalid
URL: https://github.com/apache/incubator-iceberg/pull/301#discussion_r309836281
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/TableProperties.java
 ##########
 @@ -89,6 +89,7 @@ private TableProperties() {}
   public static final String METADATA_COMPRESSION = "write.metadata.compression-codec";
   public static final String METADATA_COMPRESSION_DEFAULT = "none";
 
+  public static final String METRICS_MODE_COLUMN_CONF_PREFIX = "write.metadata.metrics.column.";
 
 Review comment:
   +1 on this. Do we want to have it as `WRITE_METRICS_MODE_COLUMN_CONF_PREFIX` to be consistent with defaults? Is there a possibility we will have `READ_METRICS_MODE_COLUMN_CONF_PREFIX`? Not sure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org